From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [GIT pull] smp/hotplug: Removal of notifiers
Date: Mon, 26 Dec 2016 22:00:15 +0100 [thread overview]
Message-ID: <20161226210015.GA2945@nazgul.tnic> (raw)
In-Reply-To: <alpine.DEB.2.20.1612261918360.3605@nanos>
On Mon, Dec 26, 2016 at 07:21:44PM +0100, Thomas Gleixner wrote:
> Is there anything interesting error message before the BUG hits? I'll try
> to reproduce on a AMD box tomorrow.
Hmm, so lemme see if I see it correctly:
threshold_create_bank() does kobject_create_and_add(name, &dev->kobj);
and that dev thing is
struct device *dev = per_cpu(mce_device, cpu);
BUT(!), those mce_device per-CPU things get initialized in
mce_cpu_online()
|-> mce_device_create(cpu);
With a CONFIG_HOTPLUG_CPU=n .config that doesn't happen, right?
Oh, and I see what could've changed that:
8c0eeac819c8 ("x86/mcheck: Move CPU_ONLINE and CPU_DOWN_PREPARE to hotplug state machine")
And before that, we did call mce_device_create(cpu) in
mcheck_init_device() which is a device initcall and not dependent on CPU
hotplug.
And frankly, flipping back to the for_each_online_cpu(i) is yucky as
hell but I don't see any other/better solution besides pulling up
mce_device_create() into mcheck_init_device()...
Hmmm.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2016-12-26 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 13:39 Thomas Gleixner
2016-12-26 7:45 ` Markus Trippelsdorf
2016-12-26 11:06 ` Markus Trippelsdorf
2016-12-26 15:45 ` Markus Trippelsdorf
2016-12-26 17:31 ` Boris Ostrovsky
2016-12-26 18:21 ` Thomas Gleixner
2016-12-26 20:53 ` Boris Ostrovsky
2016-12-26 21:00 ` Borislav Petkov [this message]
2016-12-26 21:16 ` Thomas Gleixner
2016-12-26 21:42 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161226210015.GA2945@nazgul.tnic \
--to=bp@alien8.de \
--cc=bigeasy@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®