mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: kbuild-all@01.org, Mathias Nyman <mathias.nyman@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lu Baolu <baolu.lu@linux.intel.com>,
	stable@vger.kernel.org,
	Felipe Balbi <felipe.balbi@linux.intel.com>
Subject: Re: [PATCH 1/1] usb: xhci: clear EINT bit in status correctly
Date: Fri, 30 Dec 2016 13:52:01 +0800	[thread overview]
Message-ID: <201612301322.uzSZqFSy%fengguang.wu@intel.com> (raw)
In-Reply-To: <1483075770-8415-1-git-send-email-baolu.lu@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2392 bytes --]

Hi Lu,

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.10-rc1 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lu-Baolu/usb-xhci-clear-EINT-bit-in-status-correctly/20161230-133444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-randconfig-x003-201652 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/usb/host/xhci.c: In function 'xhci_stop':
>> drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
            ~~~~~^~~~~~~~~
   drivers/usb/host/xhci.c: In function 'xhci_resume':
   drivers/usb/host/xhci.c:1057:15: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
      writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
             ~~~~~^~~~~~~~~

vim +724 drivers/usb/host/xhci.c

   708	
   709		/* Deleting Compliance Mode Recovery Timer */
   710		if ((xhci->quirks & XHCI_COMP_MODE_QUIRK) &&
   711				(!(xhci_all_ports_seen_u0(xhci)))) {
   712			del_timer_sync(&xhci->comp_mode_recovery_timer);
   713			xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
   714					"%s: compliance mode recovery timer deleted",
   715					__func__);
   716		}
   717	
   718		if (xhci->quirks & XHCI_AMD_PLL_FIX)
   719			usb_amd_dev_put();
   720	
   721		xhci_dbg_trace(xhci, trace_xhci_dbg_init,
   722				"// Disabling event ring interrupts");
   723		temp = readl(&xhci->op_regs->status);
 > 724		writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
   725		temp = readl(&xhci->ir_set->irq_pending);
   726		writel(ER_IRQ_DISABLE(temp), &xhci->ir_set->irq_pending);
   727		xhci_print_ir_set(xhci, 0);
   728	
   729		xhci_dbg_trace(xhci, trace_xhci_dbg_init, "cleaning up memory");
   730		xhci_mem_cleanup(xhci);
   731		xhci_dbg_trace(xhci, trace_xhci_dbg_init,
   732				"xhci_stop completed - status = %x",

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28186 bytes --]

  reply	other threads:[~2016-12-30  5:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30  5:29 Lu Baolu
2016-12-30  5:52 ` kbuild test robot [this message]
2016-12-30  6:19 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201612301322.uzSZqFSy%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®