From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756429AbdABR4L (ORCPT ); Mon, 2 Jan 2017 12:56:11 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:39484 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756111AbdABRyh (ORCPT ); Mon, 2 Jan 2017 12:54:37 -0500 Date: Mon, 02 Jan 2017 12:54:35 -0500 (EST) Message-Id: <20170102.125435.819704695171565389.davem@davemloft.net> To: ian.kumlien@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Update pptp handling to avoid null pointer deref. v2 From: David Miller In-Reply-To: <20170102081835.25557-1-ian.kumlien@gmail.com> References: <20170101231936.5905-1-ian.kumlien@gmail.com> <20170102081835.25557-1-ian.kumlien@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Jan 2017 08:55:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ian Kumlien Date: Mon, 2 Jan 2017 09:18:35 +0100 > __skb_flow_dissect can be called with a skb or a data packet, either > can be NULL. All calls seems to have been moved to __skb_header_pointer > except the pptp handling which is still calling skb_header_pointer. ... > Fixes: ab10dccb1160 ("rps: Inspect PPTP encapsulated by GRE to get flow hash") > Signed-off-by: Ian Kumlien Applied and queued up for -stable.