From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933897AbdABSwE (ORCPT ); Mon, 2 Jan 2017 13:52:04 -0500 Received: from smtprelay0156.hostedemail.com ([216.40.44.156]:41555 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755629AbdABSvO (ORCPT ); Mon, 2 Jan 2017 13:51:14 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3874:5007:6119:6261:7875:7903:7974:8660:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12555:12740:12760:12895:13069:13148:13230:13311:13357:13439:14096:14097:14181:14659:14721:21080:21325:21434:21451:30036:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: angle37_a8c2611cc20a X-Filterd-Recvd-Size: 2397 Date: Mon, 2 Jan 2017 13:51:11 -0500 From: Steven Rostedt To: David Lin Cc: mmarek@suse.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, jbaron@akamai.com, will.deacon@arm.com Subject: Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support Message-ID: <20170102135111.26d5f5bd@grimm.local.home> In-Reply-To: References: <20161210004638.23417-1-dtwlin@google.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 1 Jan 2017 15:05:45 -0800 David Lin wrote: > +Cc: Steven Rostedt > +Cc: Will Deacon > > On Fri, Dec 9, 2016 at 4:46 PM, David Lin wrote: > > Some versions of ARM GCC compiler such as Android toolchain throws > > in a '-fpic' flag by default. This causes the gcc-goto check script > > to fail although some config would have '-fno-pic' flag in the > > KBUILD_CFLAGS. > > > > This patch passes the KBUILD_CFLAGS to the check script so that the > > script does not rely on the default config from different compilers. > > > > Signed-off-by: David Lin Acked-by: Steven Rostedt > --- > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 694111b..f667daa 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -790,7 +790,7 @@ KBUILD_CFLAGS += $(call > > cc-option,-Werror=incompatible-pointer-types) KBUILD_ARFLAGS := > > $(call ar-option,D) > > > > # check for 'asm goto' > > -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh > > $(CC)), y) +ifeq ($(shell $(CONFIG_SHELL) > > $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y) > > KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO KBUILD_AFLAGS += > > -DCC_HAVE_ASM_GOTO endif > > -- > > 2.10.2 > >