From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759451AbdACPtk (ORCPT ); Tue, 3 Jan 2017 10:49:40 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35856 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757542AbdACPsL (ORCPT ); Tue, 3 Jan 2017 10:48:11 -0500 Date: Wed, 4 Jan 2017 00:47:45 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Andrew Morton , Steven Rostedt , Peter Hurley , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 2/2] printk: always report lost messages on serial console Message-ID: <20170103154745.GA496@tigerII.localdomain> References: <20161224140902.1962-1-sergey.senozhatsky@gmail.com> <20161224140902.1962-3-sergey.senozhatsky@gmail.com> <20170103145532.GL14894@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103145532.GL14894@pathway.suse.cz> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (01/03/17 15:55), Petr Mladek wrote: [..] > This causes the opposite problem. We might print a message that was supposed > to be suppressed. so what? yes, we print a message that otherwise would have been suppressed. not a big deal. at all. we are under high printk load and the best thing we can do is to report "we are losing the messages" straight ahead. the next 'visible' message may be seconds/minutes/forever away. think of a printk() flood of messages with suppressed loglevel coming from CPUA-CPUX, big enough to drain all 'visible' loglevel messages from CPUZ. we are back to problem "a". thus I want a simple bool flag and a simple rule: we see something - we say it. [..] > The best solution seems to be to print the warning with > the next visible message. not sure. -ss