From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964807AbdACQDa (ORCPT ); Tue, 3 Jan 2017 11:03:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:36593 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759373AbdACQC2 (ORCPT ); Tue, 3 Jan 2017 11:02:28 -0500 Date: Tue, 3 Jan 2017 17:02:12 +0100 From: David Sterba To: Philippe Loctaux Cc: clm@fb.com, jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: file.c: file cleanup Message-ID: <20170103160211.GO12081@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Philippe Loctaux , clm@fb.com, jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1481897853-13232-1-git-send-email-phil@philippeloctaux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481897853-13232-1-git-send-email-phil@philippeloctaux.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 03:17:33PM +0100, Philippe Loctaux wrote: > cleaned up the file with checkpatch ^^^^^^^^^^^^^^^ Sorry, this is an example of what should not be done. Checkpatch can detect lots of things that once were valid or tolerated but are not today. There are minor coding style violations that have accumulated over the years, missing newline here and there or the extra { } around statements. We can live with that and change it eventually when modifying the surrounding code. I'm happy to apply cleanup patches that are a byproduct of actually reading the code, but just running checkpatch and generating patches is below the treshold.