From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965028AbdACQ60 (ORCPT ); Tue, 3 Jan 2017 11:58:26 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36776 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759579AbdACQ4e (ORCPT ); Tue, 3 Jan 2017 11:56:34 -0500 Date: Tue, 3 Jan 2017 18:49:55 +0200 From: Krzysztof Kozlowski To: Jaechul Lee Cc: Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Andi Shyti , Chanwoo Choi , beomho.seo@samsung.com, galaxyra@gmail.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node Message-ID: <20170103164955.2oqyd2du2dom7wym@kozik-lap> References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 04:57:17PM +0900, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Jaechul Lee > Signed-off-by: Beomho Seo > Signed-off-by: Andi Shyti The order of sign-offs should follow the order of "who touched it". I assume that the real order was like this: 1. Initially create by Beomho, 2. Adjustments by Andi, 3. Final adjustments and sending by you. If that is correct then the order should be 1->2->3. Beside of that, patch looks good. Best regards, Krzysztof