From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758946AbdACTzr (ORCPT <rfc822;w@1wt.eu>);
        Tue, 3 Jan 2017 14:55:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60554 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758805AbdACTzi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Jan 2017 14:55:38 -0500
Date: Tue, 3 Jan 2017 11:55:36 -0800
From: Jessica Yu <jeyu@redhat.com>
To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Cc: Petr Mladek <pmladek@suse.com>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@ZenIV.linux.org.uk>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: Fix usage of true and false as field names in struct taint_flag
Message-ID: <20170103195536.ggqmihably7nt6v4@jeyu>
References: <195925.1482796188@turing-police.cc.vt.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <195925.1482796188@turing-police.cc.vt.edu>
X-OS: Linux jeyu 4.7.9-100.fc23.x86_64 x86_64
User-Agent: NeoMutt/20161126 (1.7.1)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 03 Jan 2017 19:55:39 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+++ Valdis Kletnieks [26/12/16 18:49 -0500]:
>The commit 7fd8329ba502ef76dd ("taint/module: Clean up global and
>module taint flags handling") contains this chunk:
>
>+struct taint_flag {
>+       char true;      /* character printed when tainted */
>+       char false;     /* character printed when not tainted */
>+       bool module;    /* also show as a per-module taint flag */
>+};
>
>and hilarity ensues when an out-of-tree module has this:
>
># ifndef true
>#  define true  (1)
># endif
># ifndef false
>#  define false (0)
># endif
>
>Change the field names to not shadow something likely to be used
>by third-party modules.
>
>Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>Reviewed-by: Petr Mladek <pmladek@suse.com>

[ added Rusty and Larry to CC ]

Hm, you and Larry Finger sent the exact same fix at around the same
time, although I think people are leaning towards the other patch
(it's just a naming preference), see here:

   https://lkml.kernel.org/r/20161224195532.15128-1-Larry.Finger@lwfinger.net

I plan to take the other patch, but since you first reported the
issue to lkml, and additionally sent a fix in response, I will add a
Reported-by: tag to the patch so I can also give you credit.

Thanks Valdis!

Jessica