From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758170AbdADIpS (ORCPT ); Wed, 4 Jan 2017 03:45:18 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33726 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757987AbdADIpM (ORCPT ); Wed, 4 Jan 2017 03:45:12 -0500 Date: Wed, 4 Jan 2017 09:45:08 +0100 From: Daniel Vetter To: Randy Dunlap Cc: dri-devel , LKML , kbuild test robot , Ben Skeggs Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Message-ID: <20170104084508.m54kwdkl2z6s3ruk@phenom.ffwll.local> Mail-Followup-To: Randy Dunlap , dri-devel , LKML , kbuild test robot , Ben Skeggs References: <029a1ec5-48ac-a3ce-3106-430e0f2584bb@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <029a1ec5-48ac-a3ce-3106-430e0f2584bb@infradead.org> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 01, 2017 at 04:20:53PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors in nouveau driver when CONFIG_LEDS_CLASS=m and > CONFIG_DRM_NOUVEAU=y. > If LEDS_CLASS is enabled, DRM_NOUVEAU is restricted to the same > kconfig value as LEDS_CLASS. > > drivers/built-in.o: In function `nouveau_do_suspend': > nouveau_drm.c:(.text+0x2030b1): undefined reference to `nouveau_led_suspend' > drivers/built-in.o: In function `nouveau_do_resume': > nouveau_drm.c:(.text+0x2034ca): undefined reference to `nouveau_led_resume' > drivers/built-in.o: In function `nouveau_drm_unload': > nouveau_drm.c:(.text+0x203a15): undefined reference to `nouveau_led_fini' > drivers/built-in.o: In function `nouveau_drm_load': > nouveau_drm.c:(.text+0x204423): undefined reference to `nouveau_led_init' > > BTW, this line in Kbuild: > nouveau-$(CONFIG_LEDS_CLASS) += nouveau_led.o > does nothing when CONFIG_LEDS_CLASS=m and CONFIG_DRM_NOUVEAU=y. > > Signed-off-by: Randy Dunlap > Reported-by: kbuild test robot > Cc: Martin Peres > Cc: Ben Skeggs Thrown into drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/nouveau/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- lnx-410-rc2.orig/drivers/gpu/drm/nouveau/Kconfig > +++ lnx-410-rc2/drivers/gpu/drm/nouveau/Kconfig > @@ -1,6 +1,7 @@ > config DRM_NOUVEAU > tristate "Nouveau (NVIDIA) cards" > depends on DRM && PCI > + depends on LEDS_CLASS || LEDS_CLASS=n > select FW_LOADER > select DRM_KMS_HELPER > select DRM_TTM > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch