Re: [PATCH] x86, trace: Add __irq_entry annotation to x86's platform IRQ handlers

[Steven Rostedt <rostedt@goodmis.org>]

On Wed,  4 Jan 2017 12:20:33 +0100
Daniel Bristot de Oliveira <bristot@redhat.com> wrote:

> This patch adds the __irq_entry annotation to the defaults x86's
> platform IRQ handlers. ftrace's function_graph tracer uses the
> __irq_entry annotation to notify the entry and return of IRQ
> handlers.
> 
> For example, before the patch:
>   354549.667252 |   3)  d..1              |  default_idle_call() {
>   354549.667252 |   3)  d..1              |    arch_cpu_idle() {
>   354549.667253 |   3)  d..1              |      default_idle() {
>   354549.696886 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
>   354549.696886 |   3)  d..1              |          irq_enter() {
>   354549.696886 |   3)  d..1              |            rcu_irq_enter() {
> 
> After the patch:
>   366416.254476 |   3)  d..1              |    arch_cpu_idle() {
>   366416.254476 |   3)  d..1              |      default_idle() {
>   366416.261566 |   3)  d..1  ==========> |
>   366416.261566 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
>   366416.261566 |   3)  d..1              |          irq_enter() {
>   366416.261566 |   3)  d..1              |            rcu_irq_enter() {
> 
> KASAN also uses this annotation. The smp_apic_timer_interrupt
> was already annotated.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Thomas or Ingo, want to take this in tip?

-- Steve

> 
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dou Liyang <douly.fnst@cn.fujitsu.com>
> Cc: Nicolai Stange <nicstange@gmail.com>
> Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Denys Vlasenko <dvlasenk@redhat.com>
> Cc: Claudio Fontana <claudio.fontana@huawei.com>
> Cc: Aaron Lu <aaron.lu@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Wanpeng Li <wanpeng.li@hotmail.com>
> Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-edac@vger.kernel.org
> Cc: x86@kernel.org