mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: devel@linuxdriverproject.org
Cc: linux-kernel@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alex Ng <alexng@microsoft.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v2 4/4] hv_util: improve time adjustment accuracy by disabling interrupts
Date: Wed,  4 Jan 2017 18:24:39 +0100	[thread overview]
Message-ID: <20170104172439.19683-5-vkuznets@redhat.com> (raw)
In-Reply-To: <20170104172439.19683-1-vkuznets@redhat.com>

If we happen to receive interrupts during hv_set_host_time() execution
our adjustments may get inaccurate. Make the whole function atomic.
Unfortunately, we can's call do_settimeofday64() with interrupts
disabled as some cross-CPU work is being done but this call happens
very rarely.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hv/hv_util.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
index 7e97231..4e50a42 100644
--- a/drivers/hv/hv_util.c
+++ b/drivers/hv/hv_util.c
@@ -187,6 +187,9 @@ static void hv_set_host_time(struct work_struct *work)
 	struct timespec64 host_ts, our_ts;
 	struct timex txc = {0};
 	int ret;
+	unsigned long flags;
+
+	local_irq_save(flags);
 
 	wrk = container_of(work, struct adj_time_work, work);
 
@@ -218,6 +221,7 @@ static void hv_set_host_time(struct work_struct *work)
 	 * ordered to sync our time by the host.
 	 */
 	if (abs(delta) > MAXPHASE || wrk->flags & ICTIMESYNCFLAG_SYNC) {
+		local_irq_restore(flags);
 		do_settimeofday64(&host_ts);
 		return;
 	}
@@ -232,6 +236,8 @@ static void hv_set_host_time(struct work_struct *work)
 	ret = do_adjtimex(&txc);
 	if (ret)
 		pr_debug("Failed to adjust system time: %d\n", ret);
+
+	local_irq_restore(flags);
 }
 
 /*
-- 
2.9.3

  parent reply	other threads:[~2017-01-04 17:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 17:24 [PATCH v2 0/4] hv_util: adjust system time smoothly Vitaly Kuznetsov
2017-01-04 17:24 ` [PATCH v2 1/4] timekeeping: export do_adjtimex() to modules Vitaly Kuznetsov
2017-01-07  1:06   ` John Stultz
2017-01-09 13:03     ` Vitaly Kuznetsov
2017-01-04 17:24 ` [PATCH v2 2/4] hv_util: switch to using timespec64 Vitaly Kuznetsov
2017-01-07  1:04   ` John Stultz
2017-01-04 17:24 ` [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time Vitaly Kuznetsov
2017-01-04 19:09   ` Stephen Hemminger
2017-01-05 12:37     ` Vitaly Kuznetsov
2017-01-07  0:56   ` John Stultz
2017-01-04 17:24 ` Vitaly Kuznetsov [this message]
2017-01-04 19:17   ` [PATCH v2 4/4] hv_util: improve time adjustment accuracy by disabling interrupts Stephen Hemminger
2017-01-05 12:35     ` Vitaly Kuznetsov
2017-01-05 17:39       ` Stephen Hemminger
2017-01-07  1:02   ` John Stultz
2017-01-09 13:05     ` Vitaly Kuznetsov
2017-01-09 21:27 ` [PATCH v2 0/4] hv_util: adjust system time smoothly Thomas Gleixner
2017-01-10 14:30   ` Vitaly Kuznetsov
2017-01-10 14:58     ` Thomas Gleixner
2017-01-13 13:05       ` [PATCH RFC] hv_utils: implement Hyper-V PTP source Vitaly Kuznetsov
2017-01-13 14:50         ` Richard Cochran
2017-01-13 15:38           ` Vitaly Kuznetsov
2017-01-13 15:21         ` Olaf Hering
2017-01-13 15:37           ` Vitaly Kuznetsov
2017-01-16 19:29         ` Thomas Gleixner
2017-01-17  9:53           ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170104172439.19683-5-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=alexng@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=john.stultz@linaro.org \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®