From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1030378AbdAESVH (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 13:21:07 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:44004 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752317AbdAESTz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 13:19:55 -0500
Date: Thu, 05 Jan 2017 13:18:45 -0500 (EST)
Message-Id: <20170105.131845.1605952043383659916.davem@davemloft.net>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, oss-drivers@netronome.com,
        devel@linuxdriverproject.org, linux-ppp@vger.kernel.org,
        virtualization@lists.linux-foundation.org, devel@driverdev.osuosl.org,
        linux-wireless@vger.kernel.org, dev@openvswitch.org,
        sthemmin@microsoft.com
Subject: Re: [PATCH net-next] net: make ndo_get_stats64 a void function
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170105173136.2817-1-sthemmin@microsoft.com>
References: <20170105173136.2817-1-sthemmin@microsoft.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Jan 2017 09:19:36 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v05ILGqI006844

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu,  5 Jan 2017 09:31:36 -0800

> The network device operation for reading statistics is only called
> in one place, and it ignores the return value. Having a structure
> return value is potentially confusing because some future driver could
> incorrectly assume that the return value was used.
> 
> Fix all drivers with ndo_get_stats64 to have a void function.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

You missed at least one new warning, please do a fresh allmodconfig build
and watch the logs.

drivers/net/ethernet/broadcom/bnx2.c: In function ¡bnx2_get_stats64¢:
drivers/net/ethernet/broadcom/bnx2.c:6830:10: warning: ¡return¢ with a value, in function returning void

Thanks.