From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967974AbdAEHZj (ORCPT ); Thu, 5 Jan 2017 02:25:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:48585 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967039AbdAEHZH (ORCPT ); Thu, 5 Jan 2017 02:25:07 -0500 Date: Thu, 5 Jan 2017 08:24:43 +0100 From: Jan Kara To: Jeff Layton Cc: Jan Kara , tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields Message-ID: <20170105072443.GB7166@quack2.suse.cz> References: <1482249341-21113-1-git-send-email-jlayton@redhat.com> <20170104154332.GA3607@quack2.suse.cz> <1483561288.1826.1.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483561288.1826.1.camel@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04-01-17 15:21:28, Jeff Layton wrote: > On Wed, 2017-01-04 at 16:43 +0100, Jan Kara wrote: > > On Tue 20-12-16 10:55:41, Jeff Layton wrote: > > > > > > For some odd reason, it forces a byte-by-byte copy of each field. A > > > plain old swap() on most of these fields would be more efficient. We > > > do need to retain one memswap however as that field is an array. > > > > > > Signed-off-by: Jeff Layton > > > > Looks good to me. You can add: > > > > Reviewed-by: Jan Kara > > > > Honza > > > > Thanks. Yeah, it's certainly nothing critical -- just something I > noticed while looking at the i_version rework. Seems like it might be > good to let soak in next for v4.11? Yeah, it is definitely 4.11 material. I believe he'll pick up the patch to his tree once he starts accumulating patches for the next merge window. Honza -- Jan Kara SUSE Labs, CR