From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760722AbdAEIBP (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 03:01:15 -0500
Received: from mail-wj0-f196.google.com ([209.85.210.196]:33999 "EHLO
        mail-wj0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751026AbdAEIBI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 03:01:08 -0500
Date: Thu, 5 Jan 2017 09:01:04 +0100
From: Daniel Vetter <daniel@ffwll.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        kbuild test robot <fengguang.wu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m
Message-ID: <20170105080104.7m6cnfjavjdgngml@phenom.ffwll.local>
Mail-Followup-To: Randy Dunlap <rdunlap@infradead.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        kbuild test robot <fengguang.wu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Ben Skeggs <bskeggs@redhat.com>
References: <029a1ec5-48ac-a3ce-3106-430e0f2584bb@infradead.org>
 <20170104084508.m54kwdkl2z6s3ruk@phenom.ffwll.local>
 <87k2aamxni.fsf@intel.com>
 <f814c5fd-8aad-731b-e7b6-51930ff23593@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f814c5fd-8aad-731b-e7b6-51930ff23593@infradead.org>
X-Operating-System: Linux phenom 4.8.0-1-amd64 
User-Agent: NeoMutt/20161126 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 04, 2017 at 02:24:51PM -0800, Randy Dunlap wrote:
> On 01/04/17 11:29, Jani Nikula wrote:
> > On Wed, 04 Jan 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> >> On Sun, Jan 01, 2017 at 04:20:53PM -0800, Randy Dunlap wrote:
> >>> From: Randy Dunlap <rdunlap@infradead.org>
> >>>
> >>> Fix build errors in nouveau driver when CONFIG_LEDS_CLASS=m and
> >>> CONFIG_DRM_NOUVEAU=y.
> >>> If LEDS_CLASS is enabled, DRM_NOUVEAU is restricted to the same
> >>> kconfig value as LEDS_CLASS.
> >>>
> >>> drivers/built-in.o: In function `nouveau_do_suspend':
> >>> nouveau_drm.c:(.text+0x2030b1): undefined reference to `nouveau_led_suspend'
> >>> drivers/built-in.o: In function `nouveau_do_resume':
> >>> nouveau_drm.c:(.text+0x2034ca): undefined reference to `nouveau_led_resume'
> >>> drivers/built-in.o: In function `nouveau_drm_unload':
> >>> nouveau_drm.c:(.text+0x203a15): undefined reference to `nouveau_led_fini'
> >>> drivers/built-in.o: In function `nouveau_drm_load':
> >>> nouveau_drm.c:(.text+0x204423): undefined reference to `nouveau_led_init'
> >>>
> >>> BTW, this line in Kbuild:
> >>> nouveau-$(CONFIG_LEDS_CLASS) += nouveau_led.o
> >>> does nothing when CONFIG_LEDS_CLASS=m and CONFIG_DRM_NOUVEAU=y.
> >>>
> >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> >>> Cc: Martin Peres <martin.peres@free.fr>
> >>> Cc: Ben Skeggs <bskeggs@redhat.com>
> >>
> >> Thrown into drm-misc, thanks.
> > 
> > Randy, this results in the following recursive dependency using the
> > attached config.
> > 
> 
> Hi,
> Please drop the patch for now.  If there is an alternative patch,
> that's good.  Otherwise I'll look for a solution.

Ok, pushed a revert. I guess I'll stop touching Kconfig stuff again for
the next few months ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch