From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk
Subject: Re: [PATCH] lib/vsprintf.c: remove %Z support
Date: Thu, 5 Jan 2017 16:07:48 -0800 [thread overview]
Message-ID: <20170105160748.1f3696c51cd4e56de132243d@linux-foundation.org> (raw)
In-Reply-To: <20170103230126.GA30170@avx2>
On Wed, 4 Jan 2017 02:01:27 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Now that %z is standartised in C99 there is no reason to support %Z.
> Unlike %L it doesn't even make format strings smaller.
>
> Use BUILD_BUG_ON in a couple ATM drivers.
>
> In case anyone didn't notice lib/vsprintf.o is about half of SLUB
> which is in my opinion is quite an achievement. Hopefully this patch
> inspires someone else to trim vsprintf.c more.
There's a risk that more %Z uses will sneak into the tree during the
4.10 development cycle, and possibly even later. So I added a
note-to-self to re-grep the tree before sending this upstream, but that
won't prevent people adding new instances later on: code which was
tested under earlier kernels which has %Z support.
The best suggestion I have is to add a checkpatch rule to try to catch
new %Z's being added.
next prev parent reply other threads:[~2017-01-06 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 23:01 Alexey Dobriyan
2017-01-04 9:33 ` Andy Shevchenko
2017-01-10 0:05 ` Alexey Dobriyan
2017-01-06 0:07 ` Andrew Morton [this message]
2017-01-09 23:59 ` [PATCH] checkpatch.pl: warn against using %Z Alexey Dobriyan
2017-01-09 22:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105160748.1f3696c51cd4e56de132243d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome