From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbdAFAed (ORCPT ); Thu, 5 Jan 2017 19:34:33 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35110 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdAFAeZ (ORCPT ); Thu, 5 Jan 2017 19:34:25 -0500 Date: Thu, 5 Jan 2017 16:35:27 -0800 From: Andrew Morton To: Thomas Garnier Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, jsperbeck@google.com Subject: Re: [PATCH] Fix SLAB freelist randomization duplicate entries Message-Id: <20170105163527.d37a29d6e7b3bfdafd7472d2@linux-foundation.org> In-Reply-To: <20170103181908.143178-1-thgarnie@google.com> References: <20170103181908.143178-1-thgarnie@google.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Jan 2017 10:19:08 -0800 Thomas Garnier wrote: > This patch fixes a bug in the freelist randomization code. When a high > random number is used, the freelist will contain duplicate entries. It > will result in different allocations sharing the same chunk. Important: what are the user-visible runtime effects of the bug? > Fixes: c7ce4f60ac19 ("mm: SLAB freelist randomization") > Signed-off-by: John Sperbeck > Reviewed-by: Thomas Garnier This should have been signed off by yourself. I'm guessing that the author was in fact John? If so, you should indicate this by putting his From: line at the start of the changelog. Otherwise, authorship will default to the sender (ie, yourself).