From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969556AbdAEQmA (ORCPT ); Thu, 5 Jan 2017 11:42:00 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:55364 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757579AbdAEQlo (ORCPT ); Thu, 5 Jan 2017 11:41:44 -0500 Date: Thu, 5 Jan 2017 16:40:16 +0000 From: One Thousand Gnomes To: Thadeu Lima de Souza Cascardo Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Russell King , "Theodore Ts'o" Subject: Re: [PATCH] serial/8250: remove comment about schedule_timeout Message-ID: <20170105164016.79c6e594@lxorguk.ukuu.org.uk> In-Reply-To: <20170105154840.24795-1-cascardo@canonical.com> References: <20170105154840.24795-1-cascardo@canonical.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Jan 2017 13:48:40 -0200 Thadeu Lima de Souza Cascardo wrote: > Ted T'so has added the function size_fifo in 1999 for the 2.3 series > [1], a long time ago. > > During the 2.5 cycle, Russell King has restructured the serial drivers > and, in that process, has suggested using schedule_timeout instead of > mdelay in size_fifo. [2] > > It was only at 2.6.7 that Greg Kroah-Hartman added the msleep function > to the core kernel, as people were starting to duplicate it. [3] > > However, as size_fifo is called under a spinlock from the autoconfig > function, we might not use msleep here, so removing that comment is the > appropriate thing to do. No.. it's still a flaw in the driver that we can't use msleep here. It's one of those things that people want to know if the probe locking ever gets restructured. Alan