From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756863AbdAERvk (ORCPT ); Thu, 5 Jan 2017 12:51:40 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:36431 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757751AbdAERvI (ORCPT ); Thu, 5 Jan 2017 12:51:08 -0500 Date: Thu, 5 Jan 2017 18:50:10 +0100 From: Maxime Ripard To: Andre Przywara Cc: Ulf Hansson , Chen-Yu Tsai , Hans De Goede , Icenowy Zheng , Mark Rutland , Rob Herring , devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: dts: sun50i: add MMC nodes Message-ID: <20170105175010.j3qpqqkj3kmgrmyc@lukather> References: <1483398226-29321-1-git-send-email-andre.przywara@arm.com> <1483398226-29321-4-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="unu55hffykuh5z4a" Content-Disposition: inline In-Reply-To: <1483398226-29321-4-git-send-email-andre.przywara@arm.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --unu55hffykuh5z4a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 02, 2017 at 11:03:44PM +0000, Andre Przywara wrote: > Signed-off-by: Andre Przywara > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 67 +++++++++++++++++++++= ++++++ > 1 file changed, 67 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/b= oot/dts/allwinner/sun50i-a64.dtsi > index e0dcab8..c680566 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -150,6 +150,32 @@ > pins =3D "PB8", "PB9"; > function =3D "uart0"; > }; > + > + mmc0_pins: mmc0@0 { > + pins =3D "PF0", "PF1", "PF2", "PF3", "PF4", "PF5"; > + function =3D "mmc0"; > + drive-strength =3D <30>; > + }; > + > + mmc0_default_cd_pin: mmc0_cd_pin@0 { > + pins =3D "PF6"; > + function =3D "gpio_in"; > + bias-pull-up; > + }; > + > + mmc1_pins: mmc1@0 { > + pins =3D "PG0", "PG1", "PG2", "PG3", "PG4", "PG5"; > + function =3D "mmc1"; > + drive-strength =3D <30>; > + }; > + > + mmc2_pins: mmc2@0 { > + pins =3D "PC1", "PC5", "PC6", "PC8", "PC9", > + "PC10", "PC11", "PC12", "PC13", "PC14", > + "PC15", "PC16"; > + function =3D "mmc2"; > + drive-strength =3D <30>; > + }; > }; > =20 > uart0: serial@1c28000 { > @@ -240,6 +266,47 @@ > #size-cells =3D <0>; > }; > =20 > + mmc0: mmc@1c0f000 { > + compatible =3D "allwinner,sun50i-a64-mmc", > + "allwinner,sun5i-a13-mmc"; That's not correct. There's a bunch of features that are broken without A64-specific (or at least not present on the A13) quirks. Those features include for example the SDIO aggregation that are currently broken for all modes supported so far. I was in holidays and send those patches tomorrow, but you were a bit too quick :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --unu55hffykuh5z4a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYbodSAAoJEBx+YmzsjxAgFacQAL8LUqFE+kZOV6KdQfnm3/dW jrOmkgxEvgmFKX+fhwq4Zs6R4uef1f6Zc0A5T92FmucN/pCyyD434b5hdNE15RZQ 3pONd427iMXagYlWwofjBsSkVYKC6qSFNd2jtYTrKVWauOSfLt2sA4gETfVpIS9w 3SZfQM2QcsWUeTBhj0oLNmaJVkUy1ihXrgXd2m7yisrIK2iCF7U8hHlpyWDcJJku yVpy/c+W2dyIFZWqDlUKD7DsKb5KCiHkHYJFatYf+L+xnxcNtlTjQLXYOEokb9um /llLoqqMwriodnZZ7Q564hJ7z8g/bRN0nrSeXcBmJeVQUeM7a17yc2kLJxZs+xKF AAx0UQBqpH8da3zb+88Zfb1XltIT198IVxvY5fSHGeFbNWVxF5jiNOTwyI4OaZ8w 6zI9wwOnxkzkL1w1lAiDt1z1wqYhIuWSKuuPUYkZ9qi/QQhzoc62+1lPEM6g3iQL dHqjPBXi/sMnz8nte5Z2ITkIay+KElhO0tRDJL0XZq4JVTlIy5bUE2c/Q3RQgEfz 5riLj16U4OcWgfAmStGeWwYPjPO9eu9x9iGtmVk9gIS3AdEOC1mY9Qbf2BykI9LD ocuCqIcmnPmz7t3GSOyK1wIl5RabMzFBiERVgxplhFvLNugR3EWo3cSCu4xxLNW5 WyO84Cqml5NhY+jHlkdO =RvEi -----END PGP SIGNATURE----- --unu55hffykuh5z4a--