From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763289AbdAESd2 (ORCPT ); Thu, 5 Jan 2017 13:33:28 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35432 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdAEScv (ORCPT ); Thu, 5 Jan 2017 13:32:51 -0500 Date: Thu, 5 Jan 2017 20:32:42 +0200 From: Krzysztof Kozlowski To: Viresh Kumar Cc: Rafael Wysocki , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Simon Horman , Magnus Damm , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , arnd.bergmann@linaro.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org Subject: Re: [PATCH] cpufreq: Remove CONFIG_CPU_FREQ_STAT_DETAILS config option Message-ID: <20170105183242.cwyymvr37mdqb6mj@kozik-lap> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2017 at 01:57:41PM +0530, Viresh Kumar wrote: > This doesn't have any benefit apart from saving a small amount of memory > when it is disabled. The ifdef hackery in the code makes it dirty > unnecessarily. > > Clean it up by removing the Kconfig option completely. Few defconfigs > are also updated and CONFIG_CPU_FREQ_STAT_DETAILS is replaced with > CONFIG_CPU_FREQ_STAT now in them, as users wanted stats to be enabled. > > Signed-off-by: Viresh Kumar > --- > arch/arm/configs/exynos_defconfig | 2 +- > arch/arm/configs/multi_v5_defconfig | 2 +- > arch/arm/configs/multi_v7_defconfig | 2 +- > arch/arm/configs/mvebu_v5_defconfig | 2 +- > arch/arm/configs/pxa_defconfig | 2 +- > arch/arm/configs/shmobile_defconfig | 2 +- > arch/mips/configs/lemote2f_defconfig | 1 - > arch/powerpc/configs/ppc6xx_defconfig | 1 - > arch/sh/configs/sh7785lcr_32bit_defconfig | 2 +- > drivers/cpufreq/Kconfig | 8 -------- > drivers/cpufreq/cpufreq_stats.c | 14 -------------- > 11 files changed, 7 insertions(+), 31 deletions(-) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 79c415c33f69..809f0bf3042a 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -24,7 +24,7 @@ CONFIG_ARM_APPENDED_DTB=y > CONFIG_ARM_ATAG_DTB_COMPAT=y > CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc mem=256M" > CONFIG_CPU_FREQ=y > -CONFIG_CPU_FREQ_STAT_DETAILS=y > +CONFIG_CPU_FREQ_STAT=y > CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y > CONFIG_CPU_FREQ_GOV_POWERSAVE=m > CONFIG_CPU_FREQ_GOV_USERSPACE=m For Exynos: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof