From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S967210AbdAFIGy (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 03:06:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38534 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S966693AbdAFIGn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 03:06:43 -0500
Date: Fri, 6 Jan 2017 09:06:37 +0100
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Grant Grundler <grundler@chromium.org>
Cc: Jiri Kosina <jikos@kernel.org>, Dmitry Torokhov <dtor@chromium.org>,
        linux-input <linux-input@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-usb <linux-usb@vger.kernel.org>,
        Grant Grundler <grundler@google.com>
Subject: Re: [PATCH] HID: remove use of DRIVER_LICENSE
Message-ID: <20170106080637.GD15702@mail.corp.redhat.com>
References: <20170105190704.56654-1-grundler@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170105190704.56654-1-grundler@google.com>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 06 Jan 2017 08:06:44 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jan 05 2017 or thereabouts, Grant Grundler wrote:
> Local "#define DRIVER_LICENSE" obfuscates which license is used
> in MODULE_LICENSE().  "fgrep -R MODULE_LICENSE" is more informative
> when the string is hard coded in MODULE_LICENSE.
> 
> Signed-off-by: Grant Grundler <grundler@google.com>
> ---
> Most of the kernel already uses hard coded strings.
> The few places that don't are easy to fix.

FWIW:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>