From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763975AbdAFJOS convert rfc822-to-8bit (ORCPT ); Fri, 6 Jan 2017 04:14:18 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36140 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdAFJMw (ORCPT ); Fri, 6 Jan 2017 04:12:52 -0500 Date: Fri, 6 Jan 2017 11:12:44 +0200 From: Krzysztof Kozlowski To: Chanwoo Choi Cc: Krzysztof Kozlowski , Jaechul Lee , Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Javier Martinez Canillas , Andi Shyti , beomho.seo@samsung.com, galaxyra@gmail.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of ldo23 and ldo25 Message-ID: <20170106091244.3vgpw7lceqfyb446@kozik-lap> References: <1483675149-32598-1-git-send-email-jcsing.lee@samsung.com> <1483675149-32598-2-git-send-email-jcsing.lee@samsung.com> <20170106070539.wd3kfhi77pa5ekcy@kozik-lap> <586F4554.6020206@samsung.com> <20170106085026.5pfwyxt2qipzbjpy@kozik-lap> <73639ec8-028a-56a2-0b47-3465974ec3f3@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <73639ec8-028a-56a2-0b47-3465974ec3f3@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2017 at 06:06:43PM +0900, Chanwoo Choi wrote: > On 2017년 01월 06일 17:50, Krzysztof Kozlowski wrote: > > On Fri, Jan 06, 2017 at 04:20:52PM +0900, Chanwoo Choi wrote: > >> On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote: > >>> On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: > >>>> From: Chanwoo Choi > >>>> > >>>> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. > >>> > >>> Please describe what is exactly wrong and how it affects the > >>> system/user. This is going to the fixes so it needs a good explanation. > >> > >> When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E. > >> [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") > >> > >> After checking the highest version of schematic document of both TM2 and TM2E, > >> there is no difference of ldo23/ldo25 on both TM2 and TM2E. > >> - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. > >> - ldo25 isn't used on TM2/TM2E. (not connected) > >> > >> Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board. > >> this patch does not affect the operation to system/user. > > > > If it does not affect anyone (including TM2/TM2E) then this do not have > > to be a fix. Am I right? > > This patch does not affect the TM2/TM2E's operation > because ldo23/25 are not used on TM2/TM2E. Just fix the wrong information. Ah, okay, thanks for explanation. Please just rebase on current next/dt64 (or for-next or just my https://patchwork.kernel.org/patch/9500153/) so the always-off property won't be copied. I'll take it then for v4.11. Best regards, Krzysztof