From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162845AbdAFKqL (ORCPT ); Fri, 6 Jan 2017 05:46:11 -0500 Received: from argos.tuxed.org ([176.9.87.227]:33479 "EHLO argos.tuxed.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161206AbdAFKpn (ORCPT ); Fri, 6 Jan 2017 05:45:43 -0500 From: Alexander Koch To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Rob Herring , Mark Rutland , Jean Delvare , Guenter Roeck , Michael Hornung , devicetree@vger.kernel.org, Alexander Koch Subject: [PATCH v3 0/4] hwmon: adc128d818: Support missing operation modes Date: Fri, 6 Jan 2017 11:38:13 +0100 Message-Id: <20170106103817.11588-1-mail@alexanderkoch.net> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ADC128D818 offers four different chip operation modes which vary in the number and measurement types of the available input signals (see datasheet sec. 8.4.1). The current version of the driver only supports the default chip operation mode (mode 0), providing seven analog values and a temperature reading. This patch series adds support for operation modes 1-3, selectable through the device tree attribute 'ti,mode': adc1: adc128d818@1d { compatible = "ti,adc128d818"; reg = <0x1d>; mode = <1>; }; The changes are transparent as the driver defaults to keeping the currently active operation mode if no mode is specified via device tree (which is mode 0 on chip initialization). Changes from v2: - Omit device attribute refactoring (for checkpatch.pl), as requested by maintainer - Add vendor prefix 'ti,' for mode property in device tree - Drop size indication for mode property in device tree - Preserve chip operation mode if none specified in devicetree - Fix missing '\n' in dev_err() calls Changes from v1: - Add bindings document as first patch - Preserve logical atomicity of code changes - Improve sysfs device node handling (use is_visible() instead of duplicate attribute list) - Add trivial code refactoring stage for checkpatch.pl to succeed Alexander Koch (4): devicetree: hwmon: Add bindings for ADC128D818 hwmon: adc128d818: Implement mode selection via dt hwmon: adc128d818: Support operation modes 1-3 hwmon: adc128d818: Preserve operation mode .../devicetree/bindings/hwmon/adc128d818.txt | 39 ++++++ drivers/hwmon/adc128d818.c | 147 +++++++++++++++------ 2 files changed, 149 insertions(+), 37 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/adc128d818.txt -- 2.11.0