mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Tuomas Tynkkynen <tuomas@tuxera.com>,
	linux-fsdevel@vger.kernel.org,
	v9fs-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [V9fs-developer] 9pfs hangs since 4.7
Date: Fri, 6 Jan 2017 14:52:35 +0100	[thread overview]
Message-ID: <20170106145235.51630baf@bahia.lan> (raw)
In-Reply-To: <20170104230101.GG1555@ZenIV.linux.org.uk>

On Wed, 4 Jan 2017 23:01:01 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> > Here's logs that should be complete this time:
> > 
> > https://gist.githubusercontent.com/dezgeg/08629d4c8ca79da794bc087e5951e518/raw/a1a82b9bc24e5282c82beb43a9dc91974ffcf75a/9p.qemu.log
> > https://gist.githubusercontent.com/dezgeg/1d5f1cc0647e336c59989fc62780eb2e/raw/d7623755a895b0441c608ddba366d20bbf47ab0b/9p.dmesg.log  
> 
> Fun.  All requests prior to
> [  360.110282]       dd-1899    1.... 18497262us : 9p_client_req: client 18446612134390128640 request P9_TWALK tag  25
> line in dmesg had been seen by the servers; all requests starting with that
> one had not.  Replies to earlier requests kept arriving just fine.
> 

Looking at the tag numbers, I think we're hitting the hardcoded limit of 128
simultaneous requests in QEMU (which doesn't produce any error, new requests
are silently dropped).

Tuomas, can you change MAX_REQ to some higher value (< 65535 since tag is
2-byte and 0xffff is reserved) to confirm ?

> >From the server side, everything looks nice and sane - it has processed  
> all requests it had seen, and aside of slight difference in the arrival
> order server-side and client-side logs match, except for the last 26
> requests the client claims to have sent and the server has never seen.
> 
> All traffic for another client (there had been less of it) has ceased long
> before that point, so we can't really tell if it's just this client that
> got buggered.  Interesting...
> 
> Looking at the tracepoints, those requests got through p9_client_prepare_req();
> we have no idea whether it got through p9_virtio_request().  OTOH, AFAICS
> nothing had been sleeping in there...
> 
> FWIW, it might be interesting to try
> 	WARN_ON(!virtqueue_kick(chan->vq));
> in p9_virtio_request() (instead of blind virtqueue_kick(chan->vq)) and see
> if it triggers.  Incidentally, it looks like p9_virtio_request() ought to
> return an error if that happens...
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most 
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer

  reply	other threads:[~2017-01-06 16:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 19:50 Tuomas Tynkkynen
2016-11-29 16:39 ` Eric Van Hensbergen
2016-12-02 20:11   ` Tuomas Tynkkynen
2017-01-02  8:20 ` Tuomas Tynkkynen
2017-01-02 16:23   ` Al Viro
2017-01-03 23:34     ` Tuomas Tynkkynen
2017-01-04  1:47       ` Al Viro
2017-01-04 20:04         ` Tuomas Tynkkynen
2017-01-04 23:01           ` Al Viro
2017-01-06 13:52             ` Greg Kurz [this message]
2017-01-07  6:26               ` [V9fs-developer] " Al Viro
2017-01-07 15:10                 ` Greg Kurz
2017-01-07 17:19                   ` Al Viro
2017-01-07 18:15                     ` Al Viro
2017-01-08  5:46                       ` Al Viro
2017-01-10  8:16                         ` Greg Kurz
2017-01-09 18:29                     ` Greg Kurz
2017-01-09 18:39                     ` Tuomas Tynkkynen
2017-01-09 20:05                       ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106145235.51630baf@bahia.lan \
    --to=groug@kaod.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tuomas@tuxera.com \
    --cc=v9fs-developer@lists.sourceforge.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome