From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965076AbdAFPVE (ORCPT ); Fri, 6 Jan 2017 10:21:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:54493 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754407AbdAFPUy (ORCPT ); Fri, 6 Jan 2017 10:20:54 -0500 Date: Fri, 6 Jan 2017 16:20:52 +0100 From: Michal Hocko To: Eric Dumazet Cc: linux-mm@kvack.org, LKML Subject: __GFP_REPEAT usage in fq_alloc_node Message-ID: <20170106152052.GS5556@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eric, I am currently checking kmalloc with vmalloc fallback users and convert them to a new kvmalloc helper [1]. While I am adding a support for __GFP_REPEAT to kvmalloc [2] I was wondering what is the reason to use __GFP_REPEAT in fq_alloc_node in the first place. c3bd85495aef ("pkt_sched: fq: more robust memory allocation") doesn't mention anything. Could you clarify this please? Thanks! [1] http://lkml.kernel.org/r/20170102133700.1734-1-mhocko@kernel.org [2] http://lkml.kernel.org/r/20170104181229.GB10183@dhcp22.suse.cz -- Michal Hocko SUSE Labs