From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: objtool warning for wanxl_pci_init_one with gcc-7
Date: Fri, 6 Jan 2017 11:34:23 -0600 [thread overview]
Message-ID: <20170106173423.xlmkwtb3iewduqq3@treble> (raw)
In-Reply-To: <2838744.OLG82KjLgW@wuerfel>
On Wed, Jan 04, 2017 at 12:19:20PM +0100, Arnd Bergmann wrote:
> Hi Josh,
>
> I'm getting a new warning with the latest gcc-7 snapshot, I think this
> is a false positive:
>
> drivers/net/wan/wanxl.o: warning: objtool: wanxl_pci_init_one()+0x9d2: sibling call from callable instruction with changed frame pointer
>
> # /git/arm-soc/drivers/net/wan/wanxl.c:133: switch((value >> STATUS_CABLE_PM_SHIFT) & 0x7) {
> movl %eax, %ecx # value, _314
> movl %eax, %r10d # value, _224
> movq (%r15), %rdi # MEM[base: _546, offset: 0B], pretmp_490
> shrl $5, %ecx #, _314
> andl $8, %r10d #, _224
> movl %ecx, %edx # _314, tmp377
> andl $7, %edx #, tmp377
> jmp *(%r14,%rdx,8) #
> .section .rodata
> .align 8
> .align 4
> .L280:
> .quad .L278
> .quad .L278
> .quad .L279
> .quad .L281
> .quad .L282
> .quad .L305
> .quad .L278
> .quad .L306
> .text
Thanks Arnd, will take a look at it. This reminds me that I need to
ping the gcc guys about better annotations of switch statement jump
tables.
--
Josh
prev parent reply other threads:[~2017-01-06 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 11:19 Arnd Bergmann
2017-01-06 17:34 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106173423.xlmkwtb3iewduqq3@treble \
--to=jpoimboe@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®