From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941251AbdAGJdj (ORCPT <rfc822;w@1wt.eu>);
        Sat, 7 Jan 2017 04:33:39 -0500
Received: from mail-pg0-f50.google.com ([74.125.83.50]:34407 "EHLO
        mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754677AbdAGJdU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 7 Jan 2017 04:33:20 -0500
Date: Sat, 7 Jan 2017 17:33:07 +0800
From: Leo Yan <leo.yan@linaro.org>
To: John Youn <John.Youn@synopsys.com>
Cc: John Stultz <john.stultz@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux USB List <linux-usb@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Guodong Xu <guodong.xu@linaro.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: Re: [PATCH] usb: dwc2: use u32 for DT binding parameters
Message-ID: <20170107093307.GA29727@leoy-linaro>
References: <1483706731-11469-1-git-send-email-leo.yan@linaro.org>
 <CALAqxLVunQRZkQtG3u2X=igv-e7VAm6=ZbgyXj4mGSJjnBpcFQ@mail.gmail.com>
 <61dcd8f5-229c-4901-d152-e9041c7bfb4b@synopsys.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <61dcd8f5-229c-4901-d152-e9041c7bfb4b@synopsys.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 06, 2017 at 07:30:28PM -0800, John Youn wrote:
> On 1/6/2017 1:52 PM, John Stultz wrote:
> > On Fri, Jan 6, 2017 at 4:45 AM, Leo Yan <leo.yan@linaro.org> wrote:
> >> Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params")
> >> changes to type u16 for DT binding "g-rx-fifo-size" and
> >> "g-np-tx-fifo-size" but use type u32 for "g-tx-fifo-size". Finally the
> >> the first two parameters cannot be passed successfully with wrong data
> >> format. This is found the data transferring broken on 96boards Hikey.
> >>
> >> This patch is to change all parameters to u32 type, and verified on
> >> Hikey board the DT parameters can pass successfully.
> >>
> >> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > 
> > Nice!
> > 
> > This patch (while it doesn't apply cleanly to v4.10-rc2) does resolve
> > the regression I reported earlier here:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_linux-2Dusb_msg150766.html&d=DgIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=U3o8uKoKhWme5_V9D-eeCkB11BFwt4KvWztBgdE9ZpA&m=pIpbe7JcuPH0X7-CYbBt2U3yE2WPSPtrGaMQRtcvQM0&s=hYurvvfAzlq9WTDnKKUznSRb5thSAvIO9doLJOzfUSo&e= 
> > 
> > I didn't see the slight shift to u16s there.
> > 
> > Leo, does the patch need a respin, or is it against Linus' HEAD and my
> > tree is stale?

Yeah, I should respin it.

> > Anyway, after re-applying it to my tree:
> > Tested-by: John Stultz <john.stultz@linaro.org>
> > 
> 
> Thanks Leo and John.
> 
> I just sent out a rebased version for Felipe to pick up.

Thanks a lot for both of you :)

> Regards,
> John
>