From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932578AbdAGV17 (ORCPT ); Sat, 7 Jan 2017 16:27:59 -0500 Received: from imap.thunk.org ([74.207.234.97]:50926 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551AbdAGV1v (ORCPT ); Sat, 7 Jan 2017 16:27:51 -0500 Date: Sat, 7 Jan 2017 16:27:46 -0500 From: "Theodore Ts'o" To: Roman Pen Cc: Namjae Jeon , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ext4: Do not populate extents tree with outdated offsets while shifting extents Message-ID: <20170107212746.6bqohlvik7laij7i@thunk.org> Mail-Followup-To: Theodore Ts'o , Roman Pen , Namjae Jeon , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170106202601.32722-1-roman.penyaev@profitbricks.com> <20170106202601.32722-3-roman.penyaev@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170106202601.32722-3-roman.penyaev@profitbricks.com> User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2017 at 09:26:01PM +0100, Roman Pen wrote: > Inside ext4_ext_shift_extents() function ext4_find_extent() is called > without EXT4_EX_NOCACHE flag, which should prevent cache population. > > This leads to oudated offsets in the extents tree and wrong blocks > afterwards. > > Patch fixes the problem providing EXT4_EX_NOCACHE flag for each > ext4_find_extents() call inside ext4_ext_shift_extents function. > > Signed-off-by: Roman Pen Thanks, applied. - Ted