From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941991AbdAHFpS (ORCPT ); Sun, 8 Jan 2017 00:45:18 -0500 Received: from smida.it ([94.23.22.176]:58076 "EHLO smtp.smida.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752990AbdAHFpO (ORCPT ); Sun, 8 Jan 2017 00:45:14 -0500 DMARC-Filter: OpenDMARC Filter v1.3.0 smtp.smida.it 2793042B7E Authentication-Results: mail.smida.it; dmarc=fail header.from=etezian.org Date: Sun, 8 Jan 2017 14:45:04 +0900 From: Andi Shyti To: Chanwoo Choi Cc: Andi Shyti , Andi Shyti , Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Chanwoo Choi , Beomho Seo , linux-arm-kernel , linux-input@vger.kernel.org, devicetree , linux-kernel , linux-samsung-soc , Jaechul Lee , Jaechul Lee Subject: Re: [PATCH v5 5/5] arm64: dts: exynos: Add tm2 touchkey node Message-ID: <20170108054504.fssqicmeovufar2r@jack.zhora.eu> References: <20170106134350.32428-1-andi.shyti@samsung.com> <20170106134350.32428-6-andi.shyti@samsung.com> <20170107124026.gl447hl5bucdflyk@jack.zhora.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, > >> >>> + touchkey@20 { > >> >>> + compatible = "samsung,tm2-touchkey"; > >> >>> + reg = <0x20>; > >> >>> + interrupt-parent = <&gpa3>; > >> >>> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > >> >>> + vcc-supply = <&ldo32_reg>; > >> >>> + vdd-supply = <&ldo33_reg>; > >> >>> + }; > >> >>> +}; > >> >>> + > >> >>> &ldo31_reg { > >> >>> regulator-name = "TSP_VDD_1.85V_AP"; > >> >>> regulator-min-microvolt = <1850000>; > >> > >> I repiled the touchkey driver against compatible name. > >> Usually, when developing the device driver, we use the specific h/w name > >> but in this patch, the touckey dt node uses the h/w board name instead of > >> original touckhey name. > > > > this should be a device specifically done for the tm2 and we are > > not sure who is the manufacturer of the device. In order to not > > As I knew, this touchkey was made by Cypress semiconductor. > But, for more correct information, you may try to find it. The Android Kernel says that this is the cy8cmbr3xxx. I downloaded the datasheets, but it doesn't have any similarity with the device. Which means that on tm2 we don't the cy8cmbr3xxx bot something else that I even doubt comes from cypress, but I strongly believe it's a dedicated hardware. Now we have two choices: 1. drop support because we are not 100% sure on the device and supplier. 2. call it Samsung and provide support anyway as, at the end, it is a samsung hardware. With Jaechul we chose option 2. > > assign the device to the wrong manufacturer, we preferred calling > > it Samsung as it is in a Samsung device. > > As you mentioned, Samsung made not this touchkey device. It is > certainly wrong manufacturer. I have not seen to use the h/w board > name as the peripheral device name. > > I don't prefer to use the inaccurate manufacturer and device name. Eventually, Jaechul can assign the device to cypress, but the name has to remain tm2-touchkey. Something like this: compatible = "cypress,tm2-touchkey"; What do you think? Andi