From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758287AbdAIUsN (ORCPT ); Mon, 9 Jan 2017 15:48:13 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50432 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755354AbdAIUsL (ORCPT ); Mon, 9 Jan 2017 15:48:11 -0500 Date: Mon, 09 Jan 2017 15:48:09 -0500 (EST) Message-Id: <20170109.154809.833546470488398315.davem@davemloft.net> To: dhowells@redhat.com Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 0/4] afs: Refcount afs_call struct From: David Miller In-Reply-To: <148397356909.20445.15077871371099721338.stgit@warthog.procyon.org.uk> References: <148397356909.20445.15077871371099721338.stgit@warthog.procyon.org.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 09 Jan 2017 11:49:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells Date: Mon, 09 Jan 2017 14:52:49 +0000 > > These patches provide some tracepoints for AFS and fix a potential leak by > adding refcounting to the afs_call struct. > > The patches are: > > (1) Add some tracepoints for logging incoming calls and monitoring > notifications from AF_RXRPC and data reception. > > (2) Get rid of afs_wait_mode as it didn't turn out to be as useful as > initially expected. It can be brought back later if needed. This > clears some stuff out that I don't then need to fix up in (4). > > (3) Allow listen(..., 0) to be used to disable listening. This makes > shutting down the AFS cache manager server in the kernel much easier > and the accounting simpler as we can then be sure that (a) all > preallocated afs_call structs are relesed and (b) no new incoming > calls are going to be started. > > For the moment, listening cannot be reenabled. > > (4) Add refcounting to the afs_call struct to fix a potential multiple > release detected by static checking and add a tracepoint to follow the > lifecycle of afs_call objects. > > The patches can be found here also: > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20170109 Pulled, thanks David.