From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163022AbdAIQFJ (ORCPT ); Mon, 9 Jan 2017 11:05:09 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:33744 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965535AbdAIQE1 (ORCPT ); Mon, 9 Jan 2017 11:04:27 -0500 Date: Mon, 9 Jan 2017 11:04:24 -0500 From: Tejun Heo To: Geert Uytterhoeven Cc: "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] libata-eh: Use switch() instead of sparse array for protocol strings Message-ID: <20170109160424.GB12827@mtj.duckdns.org> References: <1483973368-6828-1-git-send-email-geert@linux-m68k.org> <20170109152319.GA12827@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Jan 09, 2017 at 04:40:19PM +0100, Geert Uytterhoeven wrote: > There are two more that annoy me, but I don't know how to fix them: > > ata_scsi_rbuf - 4096 +4096 > ata_force_param_buf - 4096 +4096 ata_force_param_buf is __initdata and shouldn't really matter. ata_scsi_rbuf, hmmm, idk. Maybe we can allocate it dynamically when registering the first ATA device so that systems w/o them can avoid the wastage. Thanks. -- tejun