From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936779AbdAIRMI (ORCPT ); Mon, 9 Jan 2017 12:12:08 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:49282 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935186AbdAIRMC (ORCPT ); Mon, 9 Jan 2017 12:12:02 -0500 Date: Mon, 9 Jan 2017 09:11:59 -0800 From: Guenter Roeck To: jeroen.de_wachter.ext@nokia.com Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] hwmon/tmp401: Fix some checkstyle warnings Message-ID: <20170109171159.GC16253@roeck-us.net> References: <1483980458-28202-1-git-send-email-jeroen.de_wachter.ext@nokia.com> <1483980458-28202-2-git-send-email-jeroen.de_wachter.ext@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483980458-28202-2-git-send-email-jeroen.de_wachter.ext@nokia.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 05:47:38PM +0100, jeroen.de_wachter.ext@nokia.com wrote: > From: Jeroen De Wachter > > Signed-off-by: Jeroen De Wachter > --- > drivers/hwmon/tmp401.c | 66 +++++++++++++++++++++++++------------------------- > 1 file changed, 33 insertions(+), 33 deletions(-) > > diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c > index 88b17e4..853056d 100644 > --- a/drivers/hwmon/tmp401.c > +++ b/drivers/hwmon/tmp401.c > @@ -498,40 +498,40 @@ static ssize_t set_update_interval(struct device *dev, > return count; > } > > -static SENSOR_DEVICE_ATTR_2(temp1_input, S_IRUGO, show_temp, NULL, 0, 0); > -static SENSOR_DEVICE_ATTR_2(temp1_min, S_IWUSR | S_IRUGO, show_temp, > +static SENSOR_DEVICE_ATTR_2(temp1_input, 0444, show_temp, NULL, 0, 0); > +static SENSOR_DEVICE_ATTR_2(temp1_min, 0644, show_temp, I hate this change :-(. Please don't bother. I have a coccinelle driven series in the works which makes those changes automatically for all drivers (and, along the line, simplifies the SENSOR_DEVICE_ATTR[_2] macros). Thanks, Guenter