From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937360AbdAIWZz (ORCPT ); Mon, 9 Jan 2017 17:25:55 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:46437 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934614AbdAIWZo (ORCPT ); Mon, 9 Jan 2017 17:25:44 -0500 Date: Mon, 9 Jan 2017 14:24:36 -0800 From: Shaohua Li To: Thomas Gleixner CC: Fenghua Yu , LKML , Peter Zijlstra Subject: Re: [PATCH] x86/intel_rdt: reinitialize cbm for new group allocation Message-ID: <20170109222435.GA34665@shli-mbp.local> References: <91a513378542f2d81e39baf954d8f8c447fd1943.1483747472.git.shli@fb.com> <20170109215558.GA7138@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:200::2:adc9] X-ClientProxiedBy: BY1PR18CA0035.namprd18.prod.outlook.com (10.162.126.45) To MWHPR15MB1646.namprd15.prod.outlook.com (10.175.138.23) X-MS-Office365-Filtering-Correlation-Id: a0b5de32-cecf-41be-86b9-08d438de50e7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1646; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;3:rR00QuH8IScy9fTVbHLxA7NNrLrsADk2Tz8IY+NA5SKcWCYyPhAfKX3Up5E3egXipNoIq70yxCYARYC2dDuYXF980xg8OSqhUjVKdUSzqb/P1Br+nOmV5WlyPNpKLBEWlmcBhphQYtSIG5Mljwqp/IJnLJ8t614AWI5/ysqqkeGfeGZy8ao0pWFTh63Fi9RKJmoSByZYTJBylcrfavtW38nWVyzowQbugewf/U4Ntzr+e3iI4JB47qw/li+gJrMOcFPahXYlTKUV7lkzaEjRrg==;25:bR3gJYAbGucbijRCztV1lvKq5P9ygeq3IIBvRq5rpvCrzRvEQIwvP8QBb2cXOJZX7sOlCV7E3cg3MyyPYtpX5qHZpfmr0ONwXA/Npw9iWRhrqvF076y0tuVSZbc17ENrvnu6I7PCkDGhmS2Awu/xoBRQnkkyzVaF/fzOE3QWDF4i1u7eg+2j7wEQC/AvnuzY4Kb9scRkbc07icDnYnaez0bZYoA30gMb/KmbV1TFbpEHCmAhoBBxM7s1Fj5M+bUfJuD/65FvjzyWoAWcos7uak90xwQjFgO0ieaP0ssLKE4OprPGJbk/gyaBlBFSjmDkY1nHfSUWp5xyJJHbXnBoc+lWQGDGuEEFBDZlO3IY2VeMW8rzyQO5Zqh5GDYx78e/U+KSIlgLkT4iF/UGHsvdj/6ulo7rGo1N4m/G4HjuqfwhtdxRN4JOBxR4ahCG+iBC7/T9fGJ4wiu0LUWp417++A== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;31:66107uR4T2jADsG9RGMnY1CT/fuCqizongBHa9fKy7i1lAbxFu1b1SxL0Z9unGBeSD6tOZ/xchp1XamBeZzFXUkDCLk6Fpjn7rrLgpb0uLzXdI9k9oMMys5iIw+ehL+azhtn7mZyIRVX1nTW9vMSeUYs3XbnJ/FWwOeVxMA+qOPGhdbFb8rjyatej351WagHL2l4THyKla8EhXBm+eUAQfWr0TsMHu9U5zINRUmIL00BE/DM6Ozm7GkzVz0pqZeoOH+1vQgqPm5W2yduoB371Q==;20:eWBrxpJXMcqmVDZJWhUiSsOjYrcvEtFtCdZFjYdNBu32ExeCcblL9imEsTDntz57FAclVAcT2NOSYSA1RVGRB3TnEoqHw1LHHH0dDoM61dwJ42usRcI/bQCkKksET6Wq4c2lyBtmG2dS9mA7JyX3KiwEgl/dIwLSB81IQyqdHw4vOXhX9ffcewkvs2qTywGePBzL/3Gl2DANb/c7deKIBtsIVEXJTu5SIHZQ9pZUL8R0siJxFc78n9hNC71N7VQ8EROqcsIMgW2SPDT5OKjAL8s0OdaC/xdb3iGhoOORp3uUEomaSU+9beONaFwRExGboDrH69/oFPeJy4fpcbaLLKO9a1pEjot3XqOyu2NhwWfFwInLOnRln76g2lciQ4JgReZOIzgJ6P2fS8pCjscLmjagNhOe7aKVUDf7PA8181lAQ6sf7zU7MQHg20MrbT6VpNCDqiXILZynZiHjQXb1ANxeubpyRHOGXLcOFhDsTPrf8fB33XtKxz37dEORc4Q+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123558021)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:MWHPR15MB1646;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1646; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;4:jNrS9aCvxFV1eQxGLhjAWOx6XIfAMGEPul5KkJJ/YS+QVEh5lAdyUeVBbcuafm/Qr4fOofMZitIiUM6pPBCZAEtUnEO5Azr1niyjynVwehZKjPx6XZ8AhlAyR4x8U5KJ/qjdPnXKmac9nXQ9iM2ALFOu0B6kDjXf1r5UppKUnWbTcbJHOlQ574NJJc8eJpWZZiGN3wcp7o2KDxUvGYF1c3833ZVZqh6LYkHA4W+HbxomRE+nkt+MhSW8ZDF1d/+14KuMiQRRb8YXRlX18DJNfjsQSjIgFOpVovo6Ip8OhKGHrpufUQBNk9D+zboELpgm6Auaam2B3dGekVnhMLMx5coidnxgnXX50ZUCxvZidHz+xYvy+SCIa/DLdykPcRa8nyJTDurku0NNHQ7tFUOfHKN2LaffEstIqvWpjR8czm9ZoK7goHshmhkJJmKMJGMtGbPplY2Ty5Ok7Dt/qEn42hkh+eNS4gbpNvMEEhNmVYfE06m4at43e2QhWJN1bqUqDzTi53PptKn8jKdbs0vcpv17Q5s8RhxxSXdncoXCQ9+WwY1rJvEWC2usvxpWPkVGdFL/HCPKGuEX7l/8D52B0h6XE2DFWpeKBszYi05m6ZA= X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39410400002)(39830400002)(39450400003)(189002)(24454002)(199003)(33656002)(42186005)(46406003)(83506001)(68736007)(97756001)(86362001)(305945005)(7736002)(97736004)(98436002)(4001350100001)(47776003)(50466002)(189998001)(92566002)(9686003)(101416001)(5660300001)(8676002)(2950100002)(6916009)(25786008)(110136003)(106356001)(105586002)(6506006)(38730400001)(55016002)(54906002)(2906002)(6116002)(1076002)(4326007)(76176999)(23726003)(50986999)(54356999)(81156014)(6666003)(81166006)(229853002)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1646;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR15MB1646;23:eY8FwHUbVjGmn1nX8ljZqVEpXOGw1y9hkEEnaGHN1?= =?us-ascii?Q?f+sxjiIXYyHsBRrccaPoz4O0kHCPoQVp9vyV1rup3sI5S/kBe59DHVIdVrsz?= =?us-ascii?Q?NYZ4uA5fHGsrxgf2DceSRABFRRvSpXVKqey5gqTnAFDBhro7qEQXo01XMAq/?= =?us-ascii?Q?EzPdcdSb+4J+CagYlIcEf4aKREqAKMwMLQ4lmMSOKfbv93r74V2KJEEgXtUY?= =?us-ascii?Q?JwCpXFnHDDzdfvlJn0Pjy2tjo7P0wQCPAdZHIeetz7jygNRoXtBKLAFZE/Sh?= =?us-ascii?Q?Uu0k/qhNI1W7nc+jptA3Koc4Qj7bJCVRxBwNuVZWfDRDaCX7uYk58/e2VTmX?= =?us-ascii?Q?8/yLXUGTv1odCE/aTODqFvGj85Q5qd7YYq0jeEvbnehFGBriPjz/RX2uM46E?= =?us-ascii?Q?XvU2e/pq1Sd5Y5OKFKNYvMRQFb+hJNASqX3BEEKk2GKSxMWgVp7+W5WST9MS?= =?us-ascii?Q?9rrwmxg1kIA/RYGDXL94V1LLurQBAZuUHsCqBec87CxP+JVdYrDqQ5HnD45N?= =?us-ascii?Q?vFHKKL+MRHWCkxBslybh5WgK2+CQ61x9BQe7KNmSClGSuA9ZCFnpXmt4myRF?= =?us-ascii?Q?PtAZDUai1ZYQT7hBFW94LRaFEKqHcNUe8e0w69KQPaAynZqU9J1dEK7631tm?= =?us-ascii?Q?STgIZxCY+Q+exvCNgkPpWJvoYcxw+blk8U5JOjeqklsjiORqNsOlk0qqgq5g?= =?us-ascii?Q?sDHQmVLQELuqR9Z6A8Az+IKlhJlLz7UggUVYt39KI7jYD24oosZ1vBg3p22E?= =?us-ascii?Q?4VVuMvUiXk0cabxJKS1osMTiyoSTtOTBS9RuKso0f/Q9/C/U95pW5MsLhvfR?= =?us-ascii?Q?ZizRmPhLOOusmbSIT+a3dt33tKg4wsdBcxmzTHn0lCy1psSCqDUmaEruP3n4?= =?us-ascii?Q?RTLe+XVhjDA3ZBpfg3BsAo4Vk6K8d1jyeOy4Sjfj2IRI+9kjWXAQPJWhFjtr?= =?us-ascii?Q?K0YYWlmgWAgwmvhO3XEYGQgHv16LYhWJiVrh+ywbJ3jRvSIsFaylMZXJ8LRJ?= =?us-ascii?Q?Bh+8M1HswZJP4+xQcnmc2PwQZRsnJWXop2gRwCvEb5b/r4R+ZFAqF3PPr9IP?= =?us-ascii?Q?2cpJFd+Gord8kXrLy+U0kiIdqMOSGtIFNabMSsnzDJhMfg2+LH2E6iO7N2vS?= =?us-ascii?Q?Zgpq2s+j/omtGCsQzp8XOZMinf9kjH7gQEVdZLrZsxP3FGXGI0Z7d/fRwlbA?= =?us-ascii?Q?3H655L5lyuOr1ldNkW4SREEGHjHYNp33RRqEnWRTu+EexNkvVX2DnjtfqLYO?= =?us-ascii?Q?5/Hwz97vhqSsaof6BYuNXfinQR7Q2JmrOhOXf7v?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;6:6h/WZggRYE9yZsDoiVzgsdR7Vo/f9EOOBY+xFPqFmTeewbrRWnPtLwaflydgDuWom42+B/EXsGgONQkdrA2tSB5Hwtwgs3mypVE0MRQay68ITHa0sSyOhhqgxdo7RisesF0xr0RWwXL+Gr5SzKNT1UqWCoR2ziPrIvtwtNDrCG/lCcz9qNdR4zAI2FwUkdgpFWnizMdct6AFeXoZ8Qj2yeOv12VpQZlxLJV62OAd3MEXr65KQTjN5Hq+MxfCseQn7ba8YWps1/NxWpxhIq4yaBvzMnEd4DDNf64z2GZ6zwAT+xFdWz7hZuJLlIS0Bfueq2Rm2Ntr0T7N5iPo1dowJRSN0bkrjSe7ENmKFF1rEaNQJcwfo3XUPjpzkbLNM7PtOR8jOrz1QTcogyp9tTkVYjcs/lVdgpN/CXcMNnRVjzw=;5:/DzLU3FBDek+PHuukZyYLXQ/ZJk5WBU72NLChWt2YE+EjXhF4QxjhoRrgcB34Hif2IIxiTFs3DiBqhkt2TEbMRNXn2mY+f3P8L+AQ/O5yUF/mWuYZcDEfiOCsgcSOYVpJ2hIofFNElTkWtM/CVrFHYPiV075SQuOYpx6Y4CTRvY=;24:1HbuCYRmcJODHwLluQonCXmHsCbz6gKI/0K89zf2LN233yBHqOSfM7+SbSkUBR7KNZ/eYZ/uAdCWZsiVdZ5DjZxotXYTcsWI/NPfP/xaipU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;7:zwp3vS7kx+nUV8at2GB5aGZzn6cvxBx5BybOiclvfz2GvBV9SzhvP3Bwk1g2jvSgs0Rw4odnYPywu5UKIelRkkDG2Axoh+p0OS1A4wsKOCqzl3O97Vqmy5RHWbt4AUkJINoM9EUzgPQfeI2unz/OZuyknN503ZO6XiM5B5Zh06knFPdixsZGp03tNbLRgxP+iOeilTKupcyiKnjagJuAF2s0XHgUsXjQinvCSMVdhMbYjYiIv571BTtT6t4LH6gsAPDgSClw2J3Fj4p1/IQuMzJ2P6KRvEErN6ezKe/6/kNzDt9XlY3jdq6dE13VmtI6zAdNIxsyCThlAiIufiPfHjxhYOOFqiof1BdLRHBmYseZJmY0iEsKuMEfTOl7zDY7BTuUU5vUMR8sGy769L4ifJLqkNjKnroG3S/umcCeuvJhpI6whLo9UY1Eth5Ns4oZhnCejm1zvt/C+Uq6yVY3QQ==;20:YJV3aX+G8sMjQo6ImW4BG66pUMta6UNlaGMUy9uUpMiy2KgBkURCsJf+naHFNbLiPU0INzo6QolznfWycv+3JctqledU7aRmUxUwhYj1fFnsOps/vyTEysHyNsUDFexCQV2GUw6wRN911Ngx/8g2vnIel+TR64osW5Q+xtVAwNo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 22:24:45.3455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1646 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-09_16:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 11:03:59PM +0100, Thomas Gleixner wrote: > On Mon, 9 Jan 2017, Fenghua Yu wrote: > > On Fri, Jan 06, 2017 at 04:05:19PM -0800, Shaohua Li wrote: > > But since you come here now, I would think reseting the CBM in > > closid_free() is better. > > No. closid_free() is the wrong place. closid_alloc/free() merily deal with > the bitmap and nothing else. > > If you really want to do that, then this needs a seperate function called > from rmdir. > > > The reason is user can see "right" max_cbm even through rdmsr after > > rmdir, ie no gap for cbm values between rmdir and the next mkdir. > > And the value pf this is? > > The closid is not usable after the rmdir, so it's really completely > uninteresting when the user can read the old value from that configuration > MSR. > > When the closid is reused then it hardly matters either what's in those cbm > values (the old or max_cbm). It's just a bit confusing. Ok, I'm fine with current behavior. Probably document it somewhere in case others found the same issue. Thanks, Shaohua