From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941676AbdAIW1w (ORCPT ); Mon, 9 Jan 2017 17:27:52 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:35003 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933680AbdAIW1s (ORCPT ); Mon, 9 Jan 2017 17:27:48 -0500 Date: Mon, 9 Jan 2017 14:27:33 -0800 From: Shaohua Li To: Tejun Heo CC: , , , , Subject: Re: [PATCH V5 00/17] blk-throttle: add .low limit Message-ID: <20170109222732.GA35078@shli-mbp.local> References: <20170109214635.GV12827@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170109214635.GV12827@mtj.duckdns.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:200::2:adc9] X-ClientProxiedBy: MWHPR13CA0003.namprd13.prod.outlook.com (10.169.208.13) To CY4PR15MB1639.namprd15.prod.outlook.com (10.175.120.23) X-MS-Office365-Filtering-Correlation-Id: 6414f211-69c2-49a9-516b-08d438deba51 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR15MB1639; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;3:oZWSt1Gc2almuyP21BOcV50r2+9AtJ2jeUteo/eUiYI84/lAvhhOpneWMuInmBzWoEdoTDQSzAfGFhgHUHjEEU5JdoHWMk/4BVejewdew0lvyhQKOqp49+ogmktWzQxB509RUjSXHTHQoJTjwHc3Q87K+bTaer/olpDD4NNlUQlLEn/LIU0RBwZyocLkBwuFE/jOd3vrUlmvTei27nV2uwUrHNRDH4O5LstfjJQSyt35HWMT1Pg22fxHckquThI+vGCJJ6f0P0PniDjjG27PIw== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;25:90wDMZsbmQ1+aYgkRltgeARMOEPnGRfDC4XpFibkMLf00RiHl/yIBO6bu6fDm09AIYmoJGs7sf67u9FzcTnKNFqFnKJNVF/fZLlK45JpADWhH5AEDoUtNRate03PDK1IHN+KaUeIL/bfYOCQA1XMkjrN2PhmDS3VDoRFrVkg+Gb/0E4qRMO29TrlKE7fPwq5RC1ESITEgvzr1NEWOPg8jelRqUBnzuVhiBdAZX4rcxL8Y1txuITSg5Eg6+MxZWw/Q61amgiInHTe6EDRJserRHQOAkV5qCOkqcp+pT0R43drR9pdsXqnv7n+qboQW2KW/DbAP/r7qacnq86aMS+XQ7IYQWxqaZFQhLqpEMTH94O7UGJPxJxhBTeBY4dg/t035RzAtT93h94+foK9Cz7kCVAYVrgg8P4f+n6qsWzH1dBFl7DtQMSr51LgSb898OviGwczok+LwfDuzKBqz7cD3qIYSGVSbB6obai2zvdR4wY5tP6ewcjMK+UK8SXqSVXhguPnEX7L/oqy5Gv4Zf2RxznoGK7WDjhlEURilDl359oj9V3xmD9YrMELEUCjcH2tt3WZYCdZlAd47YZDZznfcNiaNEgNzF/CNMQDSHmunfKY0GVmm5UTUXX7zxjck22vmMkytOHpPDmYcnPEHLGkX5OSdjY9N0QsqLZ5NXOH5UysnveVxzHVC1ZvCpK5ZaeUnZFWC15OQCq9wO36Qo5By9DKjLLCvQfDm7IhsRYQ2qw= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;31:xvzs937uUTYVLii5XSexbBfji6HTdYzpa7/FZQ3xFlKmSENfVaj8HPKn/Brk/+exxI8ZQ4VXaRej/nTXtC46+Nh2GBkoheatLNwrktXP+irBjgl3QcbwGW/jo/O9P+wnow9xLyjHpsonrDWGtPCQxA0FbRL81ZPOo7FxP7DMw+gkSAysKMxU0cziyEGKCttltO8brzEiDIQZW2vUV1vnpzTPMYvKsqaBpcXzdvH2GX57kvuieD0YdTFiW6v6rXNO;20:r3DQszIzk+L+PM901HqNbft8cTPivyLQiWPQai9zchkQ0A/9cAz4GvbcxohDtqabjM/9TMQYOeh3fqYMWmF6qiWJF68oWpf3QEh7aMdZ5FLJktU1EruVW3otseWorrs/T4M83TsEC/Sj70EFseOZol1eF87IBSlXvEvQcOzweIsDzY/cy2xrGd0Oqswoa/LYPH6w2SIk0p8OnPBpqoVZ24XYNKgla993FPr7GgnE1DULulXZOM7I0DD2x3jCgOgTbMCazklNhhPUAojtVKyQqHEEJR2i0ovlGGozx7O4F9WPC0tXYA8m5kciRR8sDKDL2ZYD74qGEtIsAOTCNO8KwwJ7ajTOl3USEsJD6w67+2T8GlvOQVpzsLmWJbwvdsSpYgjkQnhkBQEOXWiYMgTW90YvY0ILjLLYTSzU01JFLkYuQxz9iyZo2l1qv+iHHv/UeCTTTWyZzG1YAidySqDtfuASC+T0p1Gf4Qbrhm/foRw36XU3YR2lkfdfijQ2s69V X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:CY4PR15MB1639;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1639; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;4:bLgQyZki9qJTcAVJC7eVZrCsLf97QpkC9SsSoTWn+za8J9prQOMWQ3scBssVpbH7FgZ0nSuAzH1Q1jST1qJO/cOO3Xcpr1HkOXKmKYgpiBxKjQlK2IksuaV/+nggepL8G7VxuqOMYwuZQGVy7mFuvSZjEFwPwo1RZkV5S7/JFWcNy7fz7cCptzoyCfIBwnayvHwF9jTZFcRRgfZ8xdo3jH9G0jXZ+dJ2yDo5LYkj08NraZjoLZ6l8yzcv/nvyhnIAnGrAKD1JkxVq0X8ZgCv9mThyQUbYMhPh1CWUPUVUE9/+91pM1r6IuM4U2/QyjboCfZYDqYMX3VK2LWiCT0E2iHgXo5FfD0tgWAYtYw8UwMa5xzWIvGM8IjHPosm1jel4J+8NmtBoSWKp9hnzXmdbv1YNaKXq+orW1lk+cf/FI0ahiY+WZaw6SsuBnfoP3/5p27bqG8r6FF6CQGH3u8DCNhSHe/OnVFpndB+zWtWpUWfe1kGZycQWDac/fHUYfGswgcRx0CIk5CJW6ltmZUbRrhnvbj97PuvZal7ysHP8buluNg+lND2RXrZk6jFzTPYrM4uuVP1S4mrYCHdZ2Qc7w== X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39830400002)(39410400002)(39450400003)(199003)(189002)(24454002)(68736007)(5660300001)(110136003)(305945005)(4001350100001)(8676002)(9686003)(55016002)(50466002)(83506001)(76176999)(46406003)(7736002)(92566002)(189998001)(2906002)(97736004)(54906002)(6666003)(50986999)(54356999)(6916009)(2950100002)(6116002)(101416001)(97756001)(47776003)(23726003)(1076002)(4326007)(98436002)(33656002)(86362001)(81156014)(25786008)(6506006)(38730400001)(42186005)(105586002)(106356001)(229853002)(81166006)(18370500001)(142923001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1639;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR15MB1639;23:yr7HFFkYVchMy2VCMwjLA31x+xPwESJTRCC5DaPZJ?= =?us-ascii?Q?6Wt7WBWPng40CZAE0HOUVedI8rjGjnNeSUkjwMvR7En0YHGcQ3fdxcQx5Fri?= =?us-ascii?Q?37f43zg+/xZLPNOZfuzKoozUEnAkdA5eMfimrQeV1/B9Ibzrd4bQJ4QH7Kul?= =?us-ascii?Q?lF7jykZfqmFZis3vqSlSutdDMJtaTPlJbLlREmPwu8LXl22E3hoS1rnQRcDL?= =?us-ascii?Q?Ssf9vljaebVxAydXwmSQ1GdCYkMETRBRw57do2b9qrxrnFWA/NxdTquVSmaW?= =?us-ascii?Q?d/9lYnu3PQXZxaQOZFnIcLQmszS847aMHYurxLBaLkCKk/Is1APIPf0ijhO0?= =?us-ascii?Q?UQs5Wib0W8J54F2GdTTEADCUIdi+0lUcS4hUfu1YtLk2sErekL/JRt5g4eIU?= =?us-ascii?Q?qD4lMyOYT0V36gsbquO703IX1zibETN1RZMK/gfxqVrZL+1APYdmjjHl3XqT?= =?us-ascii?Q?mjb0pGf5UqQr09AnBKHTlMlPV/9uqZmM3Icnn6Wx8cB3B9MeToM/hngUbsHz?= =?us-ascii?Q?A9C4s/HNxhdLzoF+fr5pQlFqSs+jhp/Y5fHZUgBoY5ADXuLGuMrkOWYaK7JX?= =?us-ascii?Q?zYGeOc4Gfi4QMd4txoqWl9DR1TJa1ZBXtbcPLLuQvN1pPBYioUE16BHe6zGQ?= =?us-ascii?Q?dT80I/MnXGZJe1qHVL9vRaSkWJmol7Oy4KQT5VpHnTEHp7zXX4hvzSbIjsx+?= =?us-ascii?Q?jx7qyUBouSMeraCvux3QF/oYI+prWXrjMUoQ9BcO/cZHAVSxVnVIw+kjbSPB?= =?us-ascii?Q?wJiqQjrui3h79piv9MlyazBPof2J2bc/nZUHjAai7mBss172jZxVvXF4rMYb?= =?us-ascii?Q?CHeF5/VRn8Tis46UIwHG2z1p4zhHEZxL4f/Ls129SajFIfD60Lii554r9xwB?= =?us-ascii?Q?/56a9Lq/cVeAqD4tNxQMaTdDWosojyFRQgag77Lhv+2BU1/ryyDAkelqXowD?= =?us-ascii?Q?VP9voqt1UzXgP+ccC9U3XaHJpEs0Fq9Kesnb9dk5D06vP0g6QAokEhEFCTfQ?= =?us-ascii?Q?LRx0AEcoL4Yoi3CLOs/mpYHumx+dGnbDCJ1DIWUNEyREu7WRzShYYVyKzmXF?= =?us-ascii?Q?7OrU3jrSHwIuyg43hpTT8CDDM2XzKFLBjc5iJZ/Q36ydP+WTf08LwGeMlWXu?= =?us-ascii?Q?n1rDdIhNBF1dX+LLhPnlkkPn6nXnVIyz3WuXefaoY0SijKQBdGw5zCJyWgvN?= =?us-ascii?Q?S3x2qztREZBmpvlXBsq25AuJD/gmEuUAlGZLn/VcuA9TVXJfz7B5X6PgJ3/i?= =?us-ascii?Q?xs20kbJsUJkQ0j6wyn7aQC3Dy37ZWNyfctRMbCQ4vCXYs6vkyK8eMx9qdm0G?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;6:obPGlQhpkG4yU/yrDRubr+tm6J3l/f/5fig08eFFTByu8SAMKR9kdjsIvQfvz7fP39hq/MNVNNX+gXfdBG3lMjqjFYcsmTGx6KNMT1IpTCQbmMOlY9mgRdIdGz77Dl7Wsyj1xcxzAQWClfduk0Di4092l137ujAsyhNu7r+L8hJyc4zjNjvFpxKvSIZdDRfZztMRP7FQji0A0QXqgPQGndtrSOuktZcRIp9nFun0K4sf0Rb3SYk+BEaFTdQFBNummOY7hl9RUOKknneTFq4HMfNGnaWy9VegosMMmzFWK9U+oE9Lr96eRNj1ibG3m7+ttxo4hqtU1xJ1Zk7xw+MReDrQnCkdCzy0yMDwS7sL3JH7jDiow9Ln2wCSxiGdAVsHcJGJm3/l8qqmebVcPbR06wgoHPMn86QDaPeYQkYkgHE=;5:9oe4ehSlq1TKU9Hdk7d98a28Cwg6QcUi7/yeAj5ostzepCHMngnppVnnk8Bd5zhG7OW6P+iDTI/p6uyCM0wW2dTzOMzMndRf3QTR50YgpyHVocCf196kKM8cnm5dBVLRhUmLEHcjsehr81Fzck9whCyp9I3+2eDfXFThs/t4lkI=;24:Oif1kn9AvpI7ipuXXLGvLn7E2OTojOcSpPNp0K1sHh+rlx2D4QiHVfuJzHHRltNXMS8gtB0AIqeSV1gysL/RLmyIjMqzeOI96PdgWJA+FCg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;7:EXlUEDeqwEeOfAtTN4OzyglKEwFovtPg0tbZA1oArZRHJkGEkL928YVh1BvhmT5tEGCPz79MuE95H+Mv483CydNkM5v2/ANoTI9LDfY0a4PiUJpB+6txuaTNKtK45RX2uSseOO7Yz2wZ1LBqsZe6e6l8dWb82BoP2anRK5IwHWBQZSK+NjLqPokgr9MZ1v2utibiKCB5ynqQjp/sN17tcdH/XzKEcIdQiBWTefL8RUmpxM/L5gXPNxrWvNT4Ds9JMYFaZkYCyXL3O8l3/qYfUKHjXWBxohGboe9BIXk5QtezPIfLFL5ZzuoVzCF+vEmJjUuJprtmEGjXlSKt4v3Bz4sGxK+kcIVlqbLIo9jxbUN9PLdkGwg4cnATIFvUaJOKG6R+boRpDSZyfcLfLSikd2VVnj0yWumZFCA1ae7WTJCzR3HzPJM6+heDqs2XW/cemmNWt8/+h3w9Pan4tEG7Eg==;20:VxgQ7x2C60aC2ta+CbZKKoi8VushRRGiDvc6gzigN+O+KGDbEtKA9FSPW9EJQNRcN4RNq0cRc0axgOqRuHjz3uRUvtzvpyZXSIotDM6SXZP5+tOedf8UghomomESTX4rR8lpZal3KvdEZT6fC2bzxd2pcCVMIapnq9GkfdP27Vg= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 22:27:42.1115 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1639 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-09_16:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 04:46:35PM -0500, Tejun Heo wrote: > Hello, > > Sorry about the long delay. Generally looks good to me. Overall, > there are only a few things that I think should be addressed. Thanks for your time! > * Low limit should default to zero. I forgot to change it after changing the name from high to low > * The default values and roles of idle timeout vs. latency target. > > I don't think either would be difficult to address. Oh and a bit more > documentation overall would be nice. Will fix these. > Thanks a lot for the great work and happy new year! Thanks and happy new year! Best regards, Shaohua