From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965047AbdAJQwT (ORCPT ); Tue, 10 Jan 2017 11:52:19 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:45930 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752986AbdAJQwR (ORCPT ); Tue, 10 Jan 2017 11:52:17 -0500 Date: Tue, 10 Jan 2017 11:52:13 -0500 (EST) Message-Id: <20170110.115213.1856085394233309828.davem@davemloft.net> To: j-keerthy@ti.com Cc: w-kwok2@ti.com, m-karicheri2@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stephen@networkplumber.org, m-scherban@ti.com Subject: Re: [PATCH] net: netcp: correct netcp_get_stats function signature From: David Miller In-Reply-To: <1484047585-16733-1-git-send-email-j-keerthy@ti.com> References: <1484047585-16733-1-git-send-email-j-keerthy@ti.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Jan 2017 07:53:08 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keerthy Date: Tue, 10 Jan 2017 16:56:25 +0530 > @@ -1909,7 +1909,7 @@ static int netcp_setup_tc(struct net_device *dev, u32 handle, __be16 proto, > return 0; > } > > -static struct rtnl_link_stats64 * > +void > netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats) Please do not remove the static qualifier.