From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759998AbdAJKSf (ORCPT ); Tue, 10 Jan 2017 05:18:35 -0500 Received: from mail-wj0-f194.google.com ([209.85.210.194]:33937 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631AbdAJKSc (ORCPT ); Tue, 10 Jan 2017 05:18:32 -0500 Date: Tue, 10 Jan 2017 11:18:28 +0100 From: Daniel Vetter To: Bhumika Goyal Cc: julia.lawall@lip6.fr, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/exynos: constify exynos_drm_crtc_ops structures Message-ID: <20170110101828.dtvivdtty44k7snd@phenom.ffwll.local> Mail-Followup-To: Bhumika Goyal , julia.lawall@lip6.fr, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1483984493-25284-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483984493-25284-1-git-send-email-bhumirks@gmail.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 11:24:53PM +0530, Bhumika Goyal wrote: > Declare exynos_drm_crtc_ops structures as const as they are only passed > as an argument to the function exynos_drm_crtc_create. This argument is > of type const struct exynos_drm_crtc_ops *, so exynos_drm_crtc_ops > structures having this property can be declared const. > Done using Coccinelle: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct exynos_drm_crtc_ops i@p={...}; > > @ok@ > position p; > identifier r.i; > @@ > exynos_drm_crtc_create(...,&i@p,...) > > @bad@ > position p!={r.p,ok.p}; > identifier r.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > +const > struct exynos_drm_crtc_ops i; > > File size before: > text data bss dec hex filename > 5008 280 0 5288 14a8 exynos/exynos5433_drm_decon.o > > File size after: > text data bss dec hex filename > 5120 176 0 5296 14b0 exynos/exynos5433_drm_decon.o > > Signed-off-by: Bhumika Goyal Applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > index 6ca1f31..12b9bf0 100644 > --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > @@ -470,7 +470,7 @@ static void decon_clear_channels(struct exynos_drm_crtc *crtc) > clk_disable_unprepare(ctx->clks[i]); > } > > -static struct exynos_drm_crtc_ops decon_crtc_ops = { > +static const struct exynos_drm_crtc_ops decon_crtc_ops = { > .enable = decon_enable, > .disable = decon_disable, > .enable_vblank = decon_enable_vblank, > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch