mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] ARM: dts: at91: add devicetree for the Axentia TSE-850
Date: Tue, 10 Jan 2017 11:42:48 +0100	[thread overview]
Message-ID: <20170110104248.iscurq55d7n26gfd@piout.net> (raw)
In-Reply-To: <b686fa42-bbfb-dec2-460f-ef00869bc12e@axentia.se>

On 10/01/2017 at 10:52:56 +0100, Peter Rosin wrote :
> On 2017-01-10 10:29, Alexandre Belloni wrote:
> > Hi,
> > 
> > This needs a commit message, please add one.
> 
> There's not all that much to say, but ok, I'll add something.
> 

It doesn't have to be long but it has to be present.

> > On 10/01/2017 at 09:08:51 +0100, Peter Rosin wrote :
> There's also the benefit of the increased chances of me getting
> notified of changes. I don't mind...
> 

Do you expect changes coming from third parties? I'm fine with it
anyway.

> >> +&main {
> >> +	clock-frequency = <12000000>;
> >> +};
> >> +
> > 
> > I don't think this is needed
> > 
> > 
> 
> "this"? The &main frequency, or all of them?
> 

I meant just main

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-01-10 10:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10  8:08 [PATCH v5 0/2] Support for " Peter Rosin
2017-01-10  8:08 ` [PATCH v5 1/2] ARM: dts: at91: add devicetree for the " Peter Rosin
2017-01-10  9:29   ` Alexandre Belloni
2017-01-10  9:52     ` Peter Rosin
2017-01-10 10:42       ` Alexandre Belloni [this message]
2017-01-10 11:21         ` Peter Rosin
2017-01-10 11:32           ` Alexandre Belloni
2017-01-10  8:08 ` [PATCH v5 2/2] ARM: sama5_defconfig: add support for the Axentia TSE-850 board Peter Rosin
2017-01-10  9:10   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110104248.iscurq55d7n26gfd@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=peda@axentia.se \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®