From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765546AbdAJKzF (ORCPT ); Tue, 10 Jan 2017 05:55:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:53287 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758365AbdAJKzD (ORCPT ); Tue, 10 Jan 2017 05:55:03 -0500 Date: Tue, 10 Jan 2017 11:55:01 +0100 From: Jan Kara To: Fabian Frederick Cc: Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 08/12 linux-next] udf: remove next_epos from udf_update_extent_cache() Message-ID: <20170110105501.GH4991@quack2.suse.cz> References: <1483736037-25111-1-git-send-email-fabf@skynet.be> <1483736037-25111-9-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483736037-25111-9-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06-01-17 21:53:56, Fabian Frederick wrote: > udf_update_extent_cache() is only called from inode_bmap() > with 1 for next_epos > > Signed-off-by: Fabian Frederick Thanks. Applied. Honza > --- > fs/udf/inode.c | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/fs/udf/inode.c b/fs/udf/inode.c > index 66514ad..2327f72 100644 > --- a/fs/udf/inode.c > +++ b/fs/udf/inode.c > @@ -109,7 +109,7 @@ static int udf_read_extent_cache(struct inode *inode, loff_t bcount, > > /* Add extent to extent cache */ > static void udf_update_extent_cache(struct inode *inode, loff_t estart, > - struct extent_position *pos, int next_epos) > + struct extent_position *pos) > { > struct udf_inode_info *iinfo = UDF_I(inode); > > @@ -121,16 +121,15 @@ static void udf_update_extent_cache(struct inode *inode, loff_t estart, > memcpy(&iinfo->cached_extent.epos, pos, > sizeof(struct extent_position)); > iinfo->cached_extent.lstart = estart; > - if (next_epos) > - switch (iinfo->i_alloc_type) { > - case ICBTAG_FLAG_AD_SHORT: > - iinfo->cached_extent.epos.offset -= > - sizeof(struct short_ad); > - break; > - case ICBTAG_FLAG_AD_LONG: > - iinfo->cached_extent.epos.offset -= > - sizeof(struct long_ad); > - } > + switch (iinfo->i_alloc_type) { > + case ICBTAG_FLAG_AD_SHORT: > + iinfo->cached_extent.epos.offset -= > + sizeof(struct short_ad); > + break; > + case ICBTAG_FLAG_AD_LONG: > + iinfo->cached_extent.epos.offset -= > + sizeof(struct long_ad); > + } > spin_unlock(&iinfo->i_extent_cache_lock); > } > > @@ -2286,7 +2285,7 @@ int8_t inode_bmap(struct inode *inode, sector_t block, > lbcount += *elen; > } while (lbcount <= bcount); > /* update extent cache */ > - udf_update_extent_cache(inode, lbcount - *elen, pos, 1); > + udf_update_extent_cache(inode, lbcount - *elen, pos); > *offset = (bcount + *elen - lbcount) >> blocksize_bits; > > return etype; > -- > 2.7.4 > > -- Jan Kara SUSE Labs, CR