From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935996AbdAJKzi (ORCPT ); Tue, 10 Jan 2017 05:55:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:53361 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933134AbdAJKzh (ORCPT ); Tue, 10 Jan 2017 05:55:37 -0500 Date: Tue, 10 Jan 2017 11:55:29 +0100 From: Jan Kara To: Fabian Frederick Cc: Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 09/12 linux-next] udf: merge module informations in super.c Message-ID: <20170110105529.GI4991@quack2.suse.cz> References: <1483736037-25111-1-git-send-email-fabf@skynet.be> <1483736037-25111-10-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483736037-25111-10-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06-01-17 21:53:57, Fabian Frederick wrote: > Move all module attributes at the end of one file like other FS. > > Signed-off-by: Fabian Frederick Thanks. Applied. Honza > --- > fs/udf/inode.c | 4 ---- > fs/udf/super.c | 9 ++++++--- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/fs/udf/inode.c b/fs/udf/inode.c > index 2327f72..47638eb 100644 > --- a/fs/udf/inode.c > +++ b/fs/udf/inode.c > @@ -43,10 +43,6 @@ > #include "udf_i.h" > #include "udf_sb.h" > > -MODULE_AUTHOR("Ben Fennema"); > -MODULE_DESCRIPTION("Universal Disk Format Filesystem"); > -MODULE_LICENSE("GPL"); > - > #define EXTENT_MERGE_SIZE 5 > > static umode_t udf_convert_permissions(struct fileEntry *); > diff --git a/fs/udf/super.c b/fs/udf/super.c > index 967ad87..9256117 100644 > --- a/fs/udf/super.c > +++ b/fs/udf/super.c > @@ -264,9 +264,6 @@ static void __exit exit_udf_fs(void) > destroy_inodecache(); > } > > -module_init(init_udf_fs) > -module_exit(exit_udf_fs) > - > static int udf_sb_alloc_partition_maps(struct super_block *sb, u32 count) > { > struct udf_sb_info *sbi = UDF_SB(sb); > @@ -2500,3 +2497,9 @@ static unsigned int udf_count_free(struct super_block *sb) > > return accum; > } > + > +MODULE_AUTHOR("Ben Fennema"); > +MODULE_DESCRIPTION("Universal Disk Format Filesystem"); > +MODULE_LICENSE("GPL"); > +module_init(init_udf_fs) > +module_exit(exit_udf_fs) > -- > 2.7.4 > > -- Jan Kara SUSE Labs, CR