From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965400AbdAJK7n (ORCPT ); Tue, 10 Jan 2017 05:59:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:54222 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936163AbdAJK7j (ORCPT ); Tue, 10 Jan 2017 05:59:39 -0500 Date: Tue, 10 Jan 2017 11:59:37 +0100 From: Jan Kara To: Fabian Frederick Cc: Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 12/12 linux-next] udf: check partition reference in udf_read_inode() Message-ID: <20170110105937.GK4991@quack2.suse.cz> References: <1483736037-25111-1-git-send-email-fabf@skynet.be> <1483736083-25193-1-git-send-email-fabf@skynet.be> <1483736083-25193-3-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483736083-25193-3-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06-01-17 21:54:43, Fabian Frederick wrote: > We were checking block number without checking partition. > sbi->s_partmaps[iloc->partitionReferenceNum] could lead to > bad memory access. See udf_nfs_get_inode() path for instance. > > Signed-off-by: Fabian Frederick Thanks. Applied. Honza > --- > fs/udf/inode.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/udf/inode.c b/fs/udf/inode.c > index 47638eb..3926973 100644 > --- a/fs/udf/inode.c > +++ b/fs/udf/inode.c > @@ -1276,6 +1276,12 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode) > int ret = -EIO; > > reread: > + if (iloc->partitionReferenceNum >= sbi->s_partitions) { > + udf_debug("partition reference: %d > logical volume partitions: %d\n", > + iloc->partitionReferenceNum, sbi->s_partitions); > + return -EIO; > + } > + > if (iloc->logicalBlockNum >= > sbi->s_partmaps[iloc->partitionReferenceNum].s_partition_len) { > udf_debug("block=%d, partition=%d out of range\n", > -- > 2.7.4 > > -- Jan Kara SUSE Labs, CR