From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032294AbdAJMRa (ORCPT ); Tue, 10 Jan 2017 07:17:30 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:63977 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761015AbdAJMR2 (ORCPT ); Tue, 10 Jan 2017 07:17:28 -0500 From: Arnd Bergmann To: Dmitry Torokhov Cc: Arnd Bergmann , Andrew Duggan , Christopher Heiny , Nick Dyer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol Date: Tue, 10 Jan 2017 13:16:58 +0100 Message-Id: <20170110121718.2992211-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:SuAblvnuiGA2v+s5YFNcq4ZNNicKo1IS0P+OPgeNJSHg0l9hM3s LDPDgdnvOCp94mR2VpiGQn1br1giYSfAD9LrccGywA9KkWzTYQCj2y8kHVIL4jz3Itvz6g2 s4pcLo/YgQIym3LWzrgPT4DLaagIrNF57M2CEjcSDZkrINz1HkzpTeJeosRvxTArWHlKrT2 95YFphPaCEcZsKzj++Zmg== X-UI-Out-Filterresults: notjunk:1;V01:K0:zCJuinECDvc=:Xaz/5LWXDcq64WtpG69Pem 2Wydvz13OzitQtI9IzEzea2wWr7ZTdc9Qh+g9YTCXb8fWzcEgqnHq/ygVR6M7L2vIEzdNUf6L xxi2yAIsSp+E25gJT+qqvltC6eJwcrmF1olIzZUm9mB/IfojPZ5QTTrWuWRHf9ehC3v55pmYe qWXFuXniitQ0OAE61CbiyucQ/9uyurEnIdvlmC41hjJfkFDJQqHzEpM1A+YuwwuCaEJkf4rTR JSHsRaZ95PEu6zVhUI9hjeDPi2+Pbz4e9t+GzdIDGUQEzHGVipkzc+eMozBaqFev7whzzj1xI tVxDqGLkY7XU7qn0Zln/5EZvH/6ZBvMM+jBYXIYL5Bp087icG5fRUK7yZzPzSkS65MHi8995K 3cjtVt7aBWGn9fnUnGkfe8XLR+Li9gEYO3XQSKkRN14O+DakIaqs0cbFCMEl3uHqvQTLPCdWD +qrxDnHcs7ORg4b6KGs2FS2BIINOZtKWE2wRwsmOx/HoT1e5oduhAglwdFyxOiNGl1FRYoHiy BdYuK99ML4dKVZHJKttRTlEJZ88g6yWjOQe5WWiLTEGpasHFuRwvqXyctdsXpQ+9o1pVBLzpW QgiS4BmxCCCEagrpvL6iyjrUMJHBJ7bD0kF9RyzfkiqFgvI9M7EHLBpTngpsUMhg1PAxXDf42 w2WKPtAVTfVL3kTgjd0HONsd1o9LVK4wSnxQ7o+NljUgVGXiDSBKC/UcCeHTW2p/qPmo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_INPUT=m, we get a build error for the rmi4-f03 driver, added in linux-4.10: drivers/input/built-in.o: In function `rmi_f03_attention': rmi_f03.c:(.text+0xcfe0): undefined reference to `serio_interrupt' rmi_f03.c:(.text+0xd055): undefined reference to `serio_interrupt' drivers/input/built-in.o: In function `rmi_f03_remove': rmi_f03.c:(.text+0xd115): undefined reference to `serio_unregister_port' drivers/input/built-in.o: In function `rmi_f03_probe': rmi_f03.c:(.text+0xd209): undefined reference to `__serio_register_port' If we make the driver itself a 'tristate' instead of 'bool' symbol, Kconfig ensures that it can only be a loadable module in this case, which avoids the problem. Fixes: c5e8848fc98e ("Input: synaptics-rmi4 - add support for F03") Signed-off-by: Arnd Bergmann --- drivers/input/rmi4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/rmi4/Kconfig b/drivers/input/rmi4/Kconfig index 30cc627a4f45..ad945b25722c 100644 --- a/drivers/input/rmi4/Kconfig +++ b/drivers/input/rmi4/Kconfig @@ -40,7 +40,7 @@ config RMI4_SMB called rmi_smbus. config RMI4_F03 - bool "RMI4 Function 03 (PS2 Guest)" + tristate "RMI4 Function 03 (PS2 Guest)" depends on RMI4_CORE && SERIO help Say Y here if you want to add support for RMI4 function 03. -- 2.9.0