From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764284AbdAJP2M (ORCPT ); Tue, 10 Jan 2017 10:28:12 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:53034 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762139AbdAJP2K (ORCPT ); Tue, 10 Jan 2017 10:28:10 -0500 From: Arnd Bergmann To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , QLogic-Storage-Upstream@cavium.com, Johannes Thumshirn , Nilesh Javali , Adheer Chandravanshi , Manish Rangankar , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: qedi: select UIO Date: Tue, 10 Jan 2017 16:27:29 +0100 Message-Id: <20170110152744.3139180-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:jfexDOclTBN9XWRHo+xEBKA00n0kJ6y6XIu+IWKiGGLzrxil4rm JSjcBE+0BaZkCKFg6udqYuD68N8gKAxFpxI/7tpOqZc8ZJuBX6y18z5N/CxW6Q5YBCTpGJW lT4aKCz7diADIZr1DrtM0E+A1t9AXQ8DBbt50NaznbMX+XyeijKgTm3VI1BELmuDfoNU8Vq S7wYwh/o00p1N4CRSv0vA== X-UI-Out-Filterresults: notjunk:1;V01:K0:awU2FqkOjTE=:hYSHbIUfCXgmmwj7bVG4DD rlAAcegI4OuRlSD0hKbsXXrO4WPnRNrlSQ/mcDHobBuRjFr7IgQQNKYkzLnQ0XOW/8QUKZUxE Sf4KmeQq90NSGuYBNEE0ZrylFe9HyU7TD511sJAYob1ZSbWzQGWDxfLz7gBdPymUKfvtbbTHW v5YLgqH4pU8zlgZ060aPsjy48SdWHJ8nh+64UyitwaVCZDDt/AowAF3QZZfY+BxI2rvTs1auE LkaBvhWWw/v0HEggyiuAi4Z3ce0FcSxuYIHfKdj45e7PSWdheCGG5cGQ+4G1KXj+rBIqoWJ33 Ae76DFvuSL5J3fejYeOhL/2jRIVYqXjIrWAmqNOY3G0l9sBH/zgtcsyCYEU6roJFWRIDYMSg6 T4WS9Bk6KKgLIHRptbcvK2OsYSr4PuHetPDmF78Er6mVp+ULdPExHhONhDAMUHe+S+vjwYnuW bKDz+HaDcOJZZz0xJ+pQqQXDFSggOq5TD01H5kWlLQyY4YLJbPt1dPvA17ijdvAc4B6HIZDxK dzT9UImGOJMfh3I7tqxLVudvSvpn8H1S0iIefD6jtvb70QK+sBC2L8nj+AY3Lp5N2c1Zl0KfS 1vdt55cSRRZzFxYXxvOD09WYiD2D/NLX8Avw4cHm/nu67f3mO2ojaPAFdPUE6fEgxFaTs54RV rsu0YLwwW3tb/CNBUAe9Nj/KBKRA58gN+a3z3XocXztIxU/dKDQHwZgVwEAUcPPqNmrU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added qedi driver links against the UIO framework, but can be built without that: drivers/scsi/qedi/qedi_main.o: In function `qedi_free_uio': qedi_main.c:(.text.qedi_free_uio+0x78): undefined reference to `uio_unregister_device' drivers/scsi/qedi/qedi_main.o: In function `qedi_ll2_recv_thread': qedi_main.c:(.text.qedi_ll2_recv_thread+0x18c): undefined reference to `uio_event_notify' drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.1': qedi_main.c:(.text.__qedi_probe.constprop.1+0x1368): undefined reference to `__uio_register_device' This adds a compile-time dependency. Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") Signed-off-by: Arnd Bergmann --- drivers/scsi/qedi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig index 23ca8a274586..913610f3d274 100644 --- a/drivers/scsi/qedi/Kconfig +++ b/drivers/scsi/qedi/Kconfig @@ -2,6 +2,7 @@ config QEDI tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support" depends on PCI && SCSI depends on QED + depends on UIO select SCSI_ISCSI_ATTRS select QED_LL2 select QED_ISCSI -- 2.9.0