From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940484AbdAJSWL (ORCPT ); Tue, 10 Jan 2017 13:22:11 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:38628 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940291AbdAJSVI (ORCPT ); Tue, 10 Jan 2017 13:21:08 -0500 Date: Tue, 10 Jan 2017 19:21:06 +0100 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , Stephen Boyd , Linus Walleij , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC Message-ID: <20170110182106.7q7uduxxqbzg4squ@lukather> References: <20170103151629.19447-1-icenowy@aosc.xyz> <20170103151629.19447-5-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u34jqn6krwdnlmfo" Content-Disposition: inline In-Reply-To: <20170103151629.19447-5-icenowy@aosc.xyz> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --u34jqn6krwdnlmfo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 03, 2017 at 11:16:28PM +0800, Icenowy Zheng wrote: > + uart0_pins_a: uart0@0 { > + pins =3D "PB8", "PB9"; > + function =3D "uart0"; > + bias-pull-up; Why do you need a pullup here? Looks good otherwise. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --u34jqn6krwdnlmfo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYdSYSAAoJEBx+YmzsjxAgSfcP/2WFx64B+GFcEU3zFtb+nYJ8 BwwYtBvlFTA/dMqLi7Q2L/U0hZz0MEHsw3iHW4VQ2IsBmXBQ+wsn4Br9EKNfH7He R4cP/d+OvGd+3uUwdi8ZZ29vhpmDWcZFmLk9EKkzM5UN/uTE3kz5ayego08scEDk Ce6s0UsvPDuN3ytDUl/XYegq9lY1n2NXykOiyl+QLTkNqG1eKAKiKlEnzVXBDh17 QH6R/zdsPQBwyoXq0TjXS0eMMdLF5zlruoqQ55qZw0DLrfynhUIcWHZ3tObHKhfc KVjeodOZAENtP2QRckXZyldQs3uoJSOBP15BOYu2JyE13CllesqMX9yf0YltgAR9 F1MPBrWFADJX5V6Rs+Naek+eN+EitKUYrmxBvcjKT+3jOGR8xdXx5jEvdS72kVtk YALOzLSkfe1EvTIYtbaxIYR0Eg29CxBUdTcxm2DJ7kmZOWxls5Xxzy28vQb5l0YY tubnzxXb2NjpX7hN/qEulfUi0Y2nxP1d2uAJeZF0u/CeWbNblob064BzOJrDH+sR uludE2znRWxhOxAHKHaEZaJ0rNxv6J0PJ7tg+5R9dw9/jEhEqU6WdsOBKdvCALiX PbNdaOvEu+0WyLIonxmbo8RftFdgYDywcKj63vSrVYxt5RLVuXfRNF+i3PjOTeMe Ki7Qox4oe6/8tGj9EzHK =cTOx -----END PGP SIGNATURE----- --u34jqn6krwdnlmfo--