From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941804AbdAJTQP (ORCPT ); Tue, 10 Jan 2017 14:16:15 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:39865 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939164AbdAJTPR (ORCPT ); Tue, 10 Jan 2017 14:15:17 -0500 Date: Tue, 10 Jan 2017 20:15:14 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Ulf Hansson , Rob Herring , devicetree , linux-arm-kernel , linux-kernel , "linux-mmc@vger.kernel.org" , Andre Przywara Subject: Re: [PATCH v2 6/6] arm64: allwinner: a64: Increase the MMC max frequency Message-ID: <20170110191514.kgbesffn3xqltnol@lukather> References: <3689701f93c8426bfa476e9a5f31c3642a8a898e.1483980339.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uvkf5zt67xpihfzl" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uvkf5zt67xpihfzl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Jan 10, 2017 at 01:01:20AM +0800, Chen-Yu Tsai wrote: > On Tue, Jan 10, 2017 at 12:46 AM, Maxime Ripard > wrote: > > All the controllers can have a maximum frequency of 200MHz. > > > > Since older SoCs cannot go that high, we cannot change the default maxi= mum > > frequency, but fortunately for us we have a property for that in the DT. > > > > This also has the side effect of allowing to use the MMC HS200 mode for= the > > boards that support it (with either 1.2v or 1.8v IOs). > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++ > > 1 file changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64= /boot/dts/allwinner/sun50i-a64.dtsi > > index 8e149498e096..f46ae965cf5b 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -332,6 +332,7 @@ > > resets =3D <&ccu RST_BUS_MMC0>; > > reset-names =3D "ahb"; > > interrupts =3D ; > > + max-frequency =3D <200000000>; >=20 > You also have to set one of MMC_CAP2_HS200* in the driver, > or mmc-hs200-1_8v or mmc-hs200-1_2v in the device tree to > actually use HS200, right? Yes, but that requires a board with 1.8V IOs to work properly, which not all board use, so it's probably best to enable it in the board DTS. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --uvkf5zt67xpihfzl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYdTK+AAoJEBx+YmzsjxAgq+oP/1OBvGLYw/SI/Ugdj9G3B0Nc mXEJsi6inDmPpgtUcS3CmiKv7ZhYwCkx1hEoBcLSGp+laQ55PNGWartAhYUC0bwu i3vUmlhuvcTa9xPKOz/VnU2hpKULT9NKuJ6AzjzIAfGwgYmaMRmYdAHUoQzPKNoP rjhjvEJjfjmfu5vPBnGbkyZXPf51qKqU7euP6poi1q/SwgoQW4KKCZAKMjO4ujTS ivpykZ4VwEL2FqBMiicoGxtC9rVQuqounGMOqFS3yWZu521DOTBMJOAXIeDp+3vx VcjutFOkoYV5JQqd7lOtgCt81uvx8umOX66QXLiaazWPESPr6E8gXkWgiH03FyvX 4uPaR1U5MHmsFRzhLzllSwf5ybs2BepOuQjU4rRVfDna8hIS3a5pF5h4O9FpL8z0 MFIEtc6c0RELq2uFyFmlEiAv+GqCDwQEgHUTECiMDAa7RTaQlvQnRq9aioN/uB/v Y0GYMwnoZHKeMYOoj6ldqeByxmZwj0soyaDZjSIcwX5in+XJol/UEiqifTLXPZd2 2hUCsXf07vBlQGNQLpcx9+nREOfC7CQkWF3PbbcyKih9W3BigY5Zjawro8LxWyd0 Ymj8Kgovn4UQD7eoQDJalpnVATwP8r9vIX1OvVQVxL99eeeretMtVp6e1W6l3MbE +/Ja2ROD/BeOr9HwMF6d =dys/ -----END PGP SIGNATURE----- --uvkf5zt67xpihfzl--