From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938049AbdAKOsZ (ORCPT ); Wed, 11 Jan 2017 09:48:25 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50206 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932784AbdAKOsY (ORCPT ); Wed, 11 Jan 2017 09:48:24 -0500 Date: Wed, 11 Jan 2017 09:48:20 -0500 (EST) Message-Id: <20170111.094820.1988998779765372781.davem@davemloft.net> To: arnd@arndb.de Cc: netdev@vger.kernel.org, ast@kernel.org, luto@kernel.org, augustocaringi@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: move CONFIG_SOCK_CGROUP_DATA to init/Kconfig From: David Miller In-Reply-To: <20170110120825.2984218-1-arnd@arndb.de> References: <20170110120825.2984218-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Jan 2017 05:49:15 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 10 Jan 2017 13:08:06 +0100 > We now 'select SOCK_CGROUP_DATA' but Kconfig complains that this is > not right when CONFIG_NET is disabled and there is no socket interface: > > warning: (CGROUP_BPF) selects SOCK_CGROUP_DATA which has unmet direct dependencies (NET) > > I don't know what the correct solution for this is, but simply removing > the dependency on NET from SOCK_CGROUP_DATA by moving it out of the > 'if NET' section avoids the warning and does not produce other build > errors. > > Fixes: 483c4933ea09 ("cgroup: Fix CGROUP_BPF config") > Signed-off-by: Arnd Bergmann > --- > There was an earlier patch by Augusto Mecking Caringi, which added > a dependency, see https://lkml.org/lkml/2017/1/2/296. > > I could not figure out whether CGROUP_BPF is meaningful without > CONFIG_NET, my version of the patch assumes that it is. > Applying either my version Augusto's to v4.10-rc will kill the > warning. CGROUP_BPF doesn't is not currently meaningful without CONFIG_NET, and especially SOCK_CGROUP_DATA is not meaningful without CONFIG_NET. Patch applied, thanks.