From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759160AbdAKAPD (ORCPT ); Tue, 10 Jan 2017 19:15:03 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:44922 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759116AbdAKAPB (ORCPT ); Tue, 10 Jan 2017 19:15:01 -0500 Date: Wed, 11 Jan 2017 01:14:50 +0100 From: Alexandre Belloni To: Bhumika Goyal Cc: julia.lawall@lip6.fr, a.zummo@towertech.it, rtc-linux@googlegroups.com, adi-buildroot-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: add const to rtc_class_ops structures Message-ID: <20170111001450.6kmxtinx2n2iyh5o@piout.net> References: <1483636717-30429-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483636717-30429-1-git-send-email-bhumirks@gmail.com> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/01/2017 at 22:48:37 +0530, Bhumika Goyal wrote : > Declare rtc_class_ops structures as const as they are only passed > as an argument to the function devm_rtc_device_register. This argument > is of type const struct rtc_class_ops *, so rtc_class_ops structures > having this property can be declared const. > Done using Coccinelle: > > @r1 disable optional_qualifier @ > identifier i; > position p; > @@ > static struct rtc_class_ops i@p = {...}; > > @ok1@ > identifier r1.i; > position p; > @@ > devm_rtc_device_register(...,&i@p,...) > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct rtc_class_ops i; > > Signed-off-by: Bhumika Goyal > --- > Compilation was terminated while compiling the .o files for all the > changed .c files. Therefore file size details of the .o files > could not be obtained. > > drivers/rtc/rtc-au1xxx.c | 2 +- > drivers/rtc/rtc-bfin.c | 2 +- > drivers/rtc/rtc-ls1x.c | 2 +- > drivers/rtc/rtc-sh.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > Applied and squashed in the previous one. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com