From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965320AbdAKIKF (ORCPT ); Wed, 11 Jan 2017 03:10:05 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:44845 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754127AbdAKIJn (ORCPT ); Wed, 11 Jan 2017 03:09:43 -0500 Date: Wed, 11 Jan 2017 16:09:25 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Linus Torvalds , Andrew Lutomirski , Linux Crypto Mailing List , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List Subject: Re: x86-64: Maintain 16-byte stack alignment Message-ID: <20170111080925.GA5341@gondor.apana.org.au> References: <20170110143340.GA3787@gondor.apana.org.au> <20170110143913.GA3822@gondor.apana.org.au> <20170111031124.GA4515@gondor.apana.org.au> <20170111043541.GA4944@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 08:06:54AM +0000, Ard Biesheuvel wrote: > > Couldn't we update the __aligned(x) macro to emit 32 if arch == x86 > and x == 16? All other cases should work just fine afaict Not everyone uses that macro. You'd also need to add some checks to stop people from using the gcc __attribute__ directly. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt