From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936012AbdAKJ5Y (ORCPT ); Wed, 11 Jan 2017 04:57:24 -0500 Received: from mga03.intel.com ([134.134.136.65]:50587 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935676AbdAKJ5X (ORCPT ); Wed, 11 Jan 2017 04:57:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="807573504" Date: Wed, 11 Jan 2017 11:54:50 +0200 From: Mika Westerberg To: Lukas Wunner Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Andreas Noever , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Chen Yu , Tomas Winkler , Amir Levy , Bjorn Helgaas , "Rafael J. Wysocki" Subject: Re: [PATCH v4 2/8] PCI: Allow runtime PM on Thunderbolt ports Message-ID: <20170111095450.GK2330@lahna.fi.intel.com> References: <7ddaaa371101208db7b8bc4dcc2f44c056645923.1483806825.git.lukas@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ddaaa371101208db7b8bc4dcc2f44c056645923.1483806825.git.lukas@wunner.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 08, 2017 at 09:41:45AM +0100, Lukas Wunner wrote: > Currently PCIe ports are only allowed to go to D3 if the BIOS is dated > 2015 or newer to avoid potential issues with old chipsets. However for > Thunderbolt we know that even the oldest controller, Light Ridge (2010), > is able to suspend its ports to D3 just fine. > > We're about to add runtime PM for Thunderbolt on the Mac. Apple has > released two EFI security updates in 2015 which encompass all machines > with Thunderbolt, but the achieved power saving should be made available > to users even if they haven't updated their BIOS. To this end, > special-case Thunderbolt in pci_bridge_d3_possible(). > > This allows the Thunderbolt controller to power down but the root port > to which the Thunderbolt controller is attached remains in D0 unless > the EFI update is installed. Users can pass pcie_port_pm=force on the > kernel command line if they cannot install the EFI update but still want > to benefit from the additional power saving of putting the root port > into D3. In practice, root ports can be suspended to D3 without issues > at least on 2012 Ivy Bridge machines. > > If the BIOS cut-off date is ever lowered to 2010, the Thunderbolt > special case can be removed. > > Cc: Mika Westerberg Reviewed-by: Mika Westerberg