From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761437AbdAKKRM (ORCPT ); Wed, 11 Jan 2017 05:17:12 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:45558 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753331AbdAKKRK (ORCPT ); Wed, 11 Jan 2017 05:17:10 -0500 Date: Wed, 11 Jan 2017 11:17:08 +0100 From: Alexandre Belloni To: Amelie DELAUNAY Cc: Alessandro Zummo , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Russell King , "rtc-linux@googlegroups.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Gabriel FERNANDEZ Subject: Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Message-ID: <20170111101708.ujcgo7kpyywymyzp@piout.net> References: <1483623809-29937-1-git-send-email-amelie.delaunay@st.com> <1483623809-29937-4-git-send-email-amelie.delaunay@st.com> <20170111000803.mlie6kizcsj2o7lh@piout.net> <1feb3a23-7450-2b5c-9c1c-c7ecacd7fa17@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1feb3a23-7450-2b5c-9c1c-c7ecacd7fa17@st.com> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/2017 at 11:07:16 +0100, Amelie DELAUNAY wrote : > > This will never happen, tm is already checked multiple times (up to > > three) in the core before this function can be called. > > > You're right. I'll remove all rtc_valid_tm calls. You can keep the one in read_time -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com