From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758021AbdAKMCJ (ORCPT ); Wed, 11 Jan 2017 07:02:09 -0500 Received: from 92-243-34-74.adsl.nanet.at ([92.243.34.74]:49865 "EHLO mail.osadl.at" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754920AbdAKMCI (ORCPT ); Wed, 11 Jan 2017 07:02:08 -0500 Date: Wed, 11 Jan 2017 12:01:34 +0000 From: Nicholas Mc Guire To: Joe Perches Cc: Nicholas Mc Guire , Bard Liao , Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: rt5651: use msleep for large delays Message-ID: <20170111120134.GA15356@osadl.at> References: <1484135376-482-1-git-send-email-hofrat@osadl.org> <1484135749.12006.23.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484135749.12006.23.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 03:55:49AM -0800, Joe Perches wrote: > On Wed, 2017-01-11 at 12:49 +0100, Nicholas Mc Guire wrote: > > ulseep_range() uses hrtimers and provides no advantage over msleep() > > for larger delays. Fix up the 75/85ms delays here to use msleep() and > > reduce the load on the hrtimer subsystem. > > If this is useful, why not convert all the large value > usleep_range uses in sound/soc/ ? > thats what Im currently doing - just that it cant be done fully automatic as it may be justified in some cases - so it needs a case-by-case review. And its not only in sound/soc/ its quite a bit in drivers/ as well. thx! hofrat