From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937374AbdAKNit (ORCPT ); Wed, 11 Jan 2017 08:38:49 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:50385 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759678AbdAKNir (ORCPT ); Wed, 11 Jan 2017 08:38:47 -0500 From: Arnd Bergmann To: Nishanth Menon , Tero Kristo , Santosh Shilimkar Cc: Arnd Bergmann , Dave Gerlach , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] firmware: ti_sci: fix strncat length check Date: Wed, 11 Jan 2017 14:37:53 +0100 Message-Id: <20170111133808.3757036-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Eg/zkD4cP1nWZZ5F6jv8lV+sDZeewhZBOl6qn8Ke9hXqqLNoJyk sUCXX+E9IpRPCiQIeMXUqnNVyY/lOV+T8HCtDT9R4C3E/I0lsU7KH0A8C5i4GRso7hXqUMx +1h3haEAMjTvaWsv+8qrhjg+3oj6BwsriN9mY9QSjnpz4w1+04JhizRgSNiHOmCqkicVAv0 M0A/Jddv0okuRTKco/4Sw== X-UI-Out-Filterresults: notjunk:1;V01:K0:a2Lu17DFH/o=:FlYwRTdEFqQ7HY/gErQF/x g45PGwQVTk5wkYXr3rfpXL1DzMQl29l98/zV2FcJUunLD5+b6dNSSctQUFUSSYGzwnww4tF5R JCq3Seh0YqHlx7JZET8xXLvhNcJ8NFv3uCKVxTBm6bGCjTHpvDaBlMo2etX3vvqpfUoTIzXzB wcBhrLgvuB4P25meqToIKFeNY/JQVv7RCbPAIMmLr6A9NNP7gSDtk4lQhZiOZ9vSlf6ZaIAh9 2EbYAjqQNvAWG/FOJz2U4AMj4lxWfYqj7S82pivjsjTMdJT1bdc1jdK7MlrOcbzFyXblHp0oR C5eQc4WRDW87kFTVKtA9oMnstvQ6a3VYa9eoHn+7tuAhhh20EOg29Os4y9mYExAZmit9XnIM9 7brCiACGy1tylntwHoMVXbsJR5L+vnlk/WHw5GO2mebas6YI5wnH+Ocfnekaubi/aRPGBKTl2 +VCXNP1/6x1QZOTLO1ZrEnDi+4aedtO+eq6HHuJL0wlbi1ChA8V9xLij7Y7GQ299PrtHjZwWH OWw7ty5A1SjBAgYxTxSQgnM6T2M5MJU46AXv539Ed39RYzN/3nLAoXxCqLgtT0dVW2Og2PSB8 m8ecbM+/r79Xo2uzRYXadgwZSldXswNLfxljXACmxQLGHAJGDR2EhQHrWoGBXGuK7SxcenGKf DBRTbsSn7Ja0xDpsBe1ujoHHHhNjVPabJ3zTbyQIPxUJsOf7bEJePVNGCXoFCRNh76Lk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 notices that the length we pass to strncat is wrong: drivers/firmware/ti_sci.c: In function 'ti_sci_probe': drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the size of the destination [-Werror=stringop-overflow=] Instead of the total length, we must pass the length of the remaining space here. Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol") Signed-off-by: Arnd Bergmann --- drivers/firmware/ti_sci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index 874ff32db366..00cfed3c3e1a 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -202,7 +202,8 @@ static int ti_sci_debugfs_create(struct platform_device *pdev, info->debug_buffer[info->debug_region_size] = 0; info->d = debugfs_create_file(strncat(debug_name, dev_name(dev), - sizeof(debug_name)), + sizeof(debug_name) - + sizeof("ti_sci_debug@")), 0444, NULL, info, &ti_sci_debug_fops); if (IS_ERR(info->d)) return PTR_ERR(info->d); -- 2.9.0